If it is up to me, I'd say the KIP is now finalized. Can I call for a [VOTE] or I need more feedback?
-----Original Message----- From: Harsha Chintalapani [mailto:[email protected]] Sent: Monday, October 22, 2018 4:36 PM To: [email protected] Subject: RE: [DISCUSS] KIP-383 Pluggable interface for SSL Factory Thanks for the changes. KIP looks good to me. -Harsha On Oct 22, 2018, 12:57 PM -0700, Pellerin, Clement <[email protected]>, wrote: > I updated the KIP. The proposed interface is now named SslFactory and the > default implementation is DefaultSslFactory. > I also mention the existing non-default constructors will be removed. > The constants for the new config keys are now declared in the interface > itself. > Please give me your feedback on this new version. > > -----Original Message----- > From: Harsha Chintalapani [mailto:[email protected]] > Sent: Friday, October 19, 2018 6:51 PM > To: [email protected]; [email protected] > Subject: RE: [DISCUSS] KIP-383 Pluggable interface for SSL Factory > > SslFactory is not a public interface for others to use. EchoServer is > internal testing. > We should make these as proposed in rejected alternatives to SslFactory and > DefaultSslFactory. > I don’t see any one using a internal class as public API. > > -Harsha
