Hi Rajini,
Overall KIP looks good to me. Is it possible to use
max.connections config that we already have, althought its per IP.
But broker level max.connections would also be good have to guard against
DOS'ing a broker.
Eitherway having constant like 20 without a configurable option doesn't sound
right and as the KIP states that one can use num.network.threads to increase
this capacity, it still not a viable option. Most of the time users tend to
keep network threads minimal and given this configuration will only need when
a burst of requests comes through , allowing users to choose that ceiling would
be beneficial. Can you add any details on why 20 is sufficient , with default
num.network.threads with 3 if one broker is getting more than 60 simultaneous
connections this would result in perceived slower responses from client side
right?
Thanks,
Harsha
On Tue, Dec 11, 2018, at 2:48 AM, Rajini Sivaram wrote:
> Hi all,
>
> I have submitted a KIP to improve fairness in channel processing in
> SocketServer to protect brokers from connection storms:
>
> -
>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-402%3A+Improve+fairness+in+SocketServer+processors
>
> Feedback and suggestions welcome.
>
> Thank you,
>
> Rajini
