+1 (binding) My only final comment would be that the topic.creation.enable setting could potentially be left out. We're still backwards compatible with what we promised before (or at least compatibility is debatable). You could enforce not being able to create topics with ACLs anyway, so avoiding the extra config might be worth the not-quite-perfect compatibility story.
-Ewen On Tue, Sep 11, 2018 at 7:01 AM Stephane Maarek < [email protected]> wrote: > +1 (non binding) > > On Tue., 11 Sep. 2018, 10:48 am Mickael Maison, <[email protected]> > wrote: > > > +1 (non-binding) > > Thanks for the KIP! > > On Tue, Sep 11, 2018 at 8:40 AM McCaig, Rhys <[email protected]> > > wrote: > > > > > > Looks great Randall > > > +1 (non-binding) > > > > > > > On Sep 9, 2018, at 7:17 PM, Gwen Shapira <[email protected]> wrote: > > > > > > > > +1 > > > > Useful improvement, thanks Randall. > > > > > > > > > > > > On Fri, Sep 7, 2018, 3:28 PM Randall Hauch <[email protected]> wrote: > > > > > > > >> I believe the feedback on KIP-158 has been addressed. I'd like to > > start a > > > >> vote. > > > >> > > > >> KIP: > > > >> > > > >> > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-158%3A+Kafka+Connect+should+allow+source+connectors+to+set+topic-specific+settings+for+new+topics > > > >> > > > >> Discussion Thread: > > > >> https://www.mail-archive.com/[email protected]/msg73775.html > > > >> > > > >> Thanks! > > > >> > > > >> Randall > > > >> > > > > > >
