I just realized that setting the client.id on the will now trigger any quota restrictions ( https://kafka.apache.org/documentation/#design_quotasconfig) on the broker. It seems like this PR will enforce quota policies that will either require admins to set limits for each task (since the chosen format is connector-*-id), or fallback to some default value.
Maybe we should mention this in the backward compatibility section for the KIP. At the same time, since there is no way atm to turn off this feature, should this feature be merged and released in the upcoming v2.3? This is something the committers can comment better. Best, On Wed, May 1, 2019 at 5:13 PM Gwen Shapira <g...@confluent.io> wrote: > hell yeah! > +1 > > > On Fri, Apr 5, 2019 at 9:08 AM Paul Davidson > <pdavid...@salesforce.com.invalid> wrote: > > > Hi all, > > > > Since we seem to have agreement in the discussion I would like to start > the > > vote on KIP-411. > > > > See: > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-411%3A+Make+default+Kafka+Connect+worker+task+client+IDs+distinct > > > > Also see the related PR: https://github.com/apache/kafka/pull/6097 > > > > Thanks to everyone who contributed! > > > > Paul > > > > > -- > *Gwen Shapira* > Product Manager | Confluent > 650.450.2760 | @gwenshap > Follow us: Twitter <https://twitter.com/ConfluentInc> | blog > <http://www.confluent.io/blog> >
