Hi all, During the implementation of KIP-460, we discovered that we had to make some minor changes to the design. I have updated the KIP wiki[1]. You can see the difference here[2].
At a high-level we made the following changes: 1. Added a top level ErrorCode to the response for errors that apply to all of the topic partitions. This is currently being used for cluster authorization errors. 2. We renamed the delayedOperation for DelayOperationPurgatory from ElectPreferredLeader to ElectLeader. [1] https://cwiki.apache.org/confluence/display/KAFKA/KIP-460%3A+Admin+Leader+Election+RPC . [2] https://cwiki.apache.org/confluence/pages/diffpagesbyversion.action?pageId=113707931&selectedPageVersions=19&selectedPageVersions=18 On Tue, May 7, 2019 at 9:59 AM Jose Armando Garcia Sancio < [email protected]> wrote: > Thanks Gwen for the clarification! > > On Mon, May 6, 2019 at 5:03 PM Gwen Shapira <[email protected]> wrote: > >> All committer votes are binding, so you have binding +1 from Colin, Jason >> and myself - which is just the 3 you need for the KIP to be accepted. >> Mickael added non-binding community support, which is great signal as >> well. >> >> On Mon, May 6, 2019 at 4:39 PM Jose Armando Garcia Sancio < >> [email protected]> wrote: >> >> > I am closing the voting. KIP is accepted with: >> > >> > +1 (binding): Colin McCabe >> > +1 (non-binding): Jason Gustafson, Gwen Shapira, Mickael Maison >> > >> > Thanks! >> > >> > On Fri, May 3, 2019 at 9:59 AM Mickael Maison <[email protected] >> > >> > wrote: >> > >> > > +1 (non binding) >> > > Thanks for the KIP >> > > >> > > On Thu, May 2, 2019 at 11:02 PM Colin McCabe <[email protected]> >> wrote: >> > > > >> > > > +1 (binding) >> > > > >> > > > thanks, Jose. >> > > > >> > > > best, >> > > > Colin >> > > > >> > > > On Wed, May 1, 2019, at 14:44, Jose Armando Garcia Sancio wrote: >> > > > > Hi all, >> > > > > >> > > > > I would like to start the voting for KIP-460: >> > > > > >> > > >> > >> https://cwiki.apache.org/confluence/display/KAFKA/KIP-460%3A+Admin+Leader+Election+RPC >> > > > > >> > > > > The thread discussion is here: >> > > > > https://www.mail-archive.com/[email protected]/msg97226.html >> > > > > >> > > > > Thanks! >> > > > > -Jose >> > > > > >> > > >> > >> > >> > -- >> > -Jose >> > >> >> >> -- >> *Gwen Shapira* >> Product Manager | Confluent >> 650.450.2760 | @gwenshap >> Follow us: Twitter <https://twitter.com/ConfluentInc> | blog >> <http://www.confluent.io/blog> >> > > > -- > -Jose > -- -Jose
