Thank you Justine for the KIP! Do you mind creating a corresponding JIRA
ticket too?

On Mon, Jun 24, 2019 at 4:51 PM Colin McCabe <cmcc...@apache.org> wrote:

> Hi Justine,
>
> Thanks for the KIP.  This looks great!
>
> In one place in the KIP, you write: "Remove
> testRoundRobinWithUnavailablePartitions() and testRoundRobin() since the
> round robin functionality of the partitioner has been removed."  You can
> skip this and similar lines.  We don't need to describe changes to internal
> test classes in the KIP since they're not visible to users or external
> developers.
>
> It seems like maybe the performance tests should get their own section.
> Right now, the way the layout is makes it look like they are part of the
> "Compatibility, Deprecation, and Migration Plan"
>
> best,
> Colin
>
>
> On Mon, Jun 24, 2019, at 14:04, Justine Olshan wrote:
> > Hello,
> > This is the discussion thread for KIP-480: Sticky Partitioner.
> >
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-480%3A+Sticky+Partitioner
> >
> > Thank you,
> > Justine Olshan
> >
>

Reply via email to