Hey there everybody, We're moving along. I wanted to come back with some updates we came up with while iterating on the PR: - Removed the ALL log level - all the rest log levels are quite standard but this is not that expected. Simpler is always better :) - We have changed the DescribeConfigs API and the Log4jController MBean's getter methods to return the ROOT log level for a logger which does not have its log level explicitly set. This is more user-friendly
Changes are reflected in the KIP Thanks, Stanislav On Wed, Jun 12, 2019 at 1:34 PM Stanislav Kozlovski <stanis...@confluent.io> wrote: > Hello, > > I finished work on an initial PR for this KIP, it is ready for review here > - https://github.com/apache/kafka/pull/6903 > > During implementation, I noticed a couple of holes in the KIP and did the > following changes: > * add LogLevelConfig public class and a few more log levels (7 total - ALL, > TRACE, DEBUG, INFO, WARN, ERROR, FATAL) > * add a new ConfigResource - DYNAMIC_BROKER_LOGGER_CONFIG > * DELETE operations in the IncrementalAlterConfigRequest will change the > logger's level to the ROOT logger's currently-set level. (we previously > thought we could return to the default - log4j does not seem to allow us to > do that) > > Feel free to re-read the KIP ( > https://cwiki.apache.org/confluence/display/KAFKA/KIP-412%3A+Extend+Admin+API+to+support+dynamic+application+log+levels) > or > go through its page history > > Thanks, > Stanislav > > On Thu, Feb 21, 2019 at 12:17 PM Stanislav Kozlovski < > stanis...@confluent.io> wrote: > >> Thanks for the interest everybody. This KIP has passed with 3 binding >> votes (Harsha, Gwen, Rajini) and 5 non-binding votes (Mickael, Jonathan, >> Dongjin, Satish, Andrew) >> >> On Thu, Feb 21, 2019 at 9:00 AM Satish Duggana <satish.dugg...@gmail.com> >> wrote: >> >>> Thanks for the KIP >>> +1 (non-binding) >>> >>> On Thu, Feb 21, 2019 at 9:38 AM Harsha <ka...@harsha.io> wrote: >>> > >>> > +1 (binding). >>> > >>> > Thanks, >>> > Harsha >>> > >>> > On Tue, Feb 19, 2019, at 7:53 AM, Andrew Schofield wrote: >>> > > Thanks for the KIP. >>> > > >>> > > +1 (non-binding) >>> > > >>> > > On 18/02/2019, 12:48, "Stanislav Kozlovski" <stanis...@confluent.io> >>> wrote: >>> > > >>> > > Hey everybody, I'm starting a VOTE thread for KIP-412. This >>> feature should >>> > > significantly improve the flexibility and ease in debugging >>> Kafka in run >>> > > time >>> > > >>> > > KIP-412 - >>> > > >>> > > >>> https://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcwiki.apache.org%2Fconfluence%2Fdisplay%2FKAFKA%2FKIP-412%253A%2BExtend%2BAdmin%2BAPI%2Bto%2Bsupport%2Bdynamic%2Bapplication%2Blog%2Blevels&data=02%7C01%7C%7C69bc63a9d7864e25ec3c08d69596eec4%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636860872825557120&sdata=XAnMhy6EPC7JkB77NBBhLR%2FvE7XrTutuS5Rlt%2FDpwfU%3D&reserved=0 >>> > > >>> > > >>> > > -- >>> > > Best, >>> > > Stanislav >>> > > >>> > > >>> > > >>> >> >> >> -- >> Best, >> Stanislav >> > > > -- > Best, > Stanislav > -- Best, Stanislav
