Hi Justine, Thanks for the KIP. This seems like a good step towards removing server-side topic auto-creation.
We should add included "client-side" to the title of the KIP somewhere, to make it clear that we're talking about client-side auto creation. The KIP says: > In order to automatically create topics with the producer, the producer's > auto.create.topics.enable config must be set to true and the broker config > should be set to false >From a user's point of view, this seems counter-intuitive. In order to >auto-create topics the broker's auto.create.topics.enable config should be set >to false? It seems like the server-side auto-create is unrelated to the >client-side auto-create. We could have both turned on (and I'm sure that in >the real world, people will try this configuration...) There's no reason not >to support this, I think. We should add some documentation explaining the difference between server-side and client-side auto-creation. Without documentation, an admin might think that they had disabled all forms of auto-creation by setting the -side setting to false-- but this is not the case, of course. best, Colin On Thu, Jul 11, 2019, at 16:22, Justine Olshan wrote: > Hi Dhruvil, > > Thanks for reading the KIP! > That was the general idea for deprecation. We would log a warning when the > config is enabled on the broker. > I also believe that there would be a change to documentation. > If there is anything else that should be done, please let me know! > > Justine > > On Thu, Jul 11, 2019 at 4:17 PM Dhruvil Shah <dhru...@confluent.io> wrote: > > > Hi Justine, > > > > Thanks for the KIP, this is great! > > > > Could you add some more information about what deprecating the broker > > configuration means? Would we log a warning in the logs when auto topic > > creation is enabled on the broker, for example? > > > > Thanks, > > Dhruvil > > > > On Thu, Jul 11, 2019 at 10:28 AM Justine Olshan <jols...@confluent.io> > > wrote: > > > > > Hello all, > > > > > > I'd like to start a discussion thread for KIP-487. > > > This KIP plans to deprecate the current system of auto-creating topics > > > through requests to the metadata and give the producer the ability to > > > automatically create topics instead. > > > > > > More information can be found here: > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-487%3A+Automatic+Topic+Creation+on+Producer > > > > > > Thank you, > > > Justine Olshan > > > > > >
