John, I'm glad to learn I'm not the only one who's re-read the metrics code multiple times.
I do wonder if the proposed names could be improved further though, given that "sum", "total", and "count" are roughly synonymous. I'm already scratching my head at what "TotalSum" means. It's clear in the context of your matrix, juxtaposed with the alternatives, but when I come across the name in isolation I suspect I'll be back looking at the implementation again. Ryanne On Fri, Jul 12, 2019, 1:45 PM John Roesler <j...@confluent.io> wrote: > Hi Kafka devs, > > Yesterday, I proposed KIP-488 as a minor cleanup of some of our metric > implementations. > > KIP-488: https://cwiki.apache.org/confluence/x/kkAyBw > > The change seems pretty uncontroversial, so I'm just going to open the > vote now. > > Feel free to veto or just request more discussion if you disagree with > the KIP. The vote will remain open for 72 hours. > > Thanks, > -John >
