Hey, On Tue, May 8, 2012 at 9:01 AM, Christian Schneider <[email protected]> wrote: > </SKIP> > - Makes our itests simpler as we do not need to sync the startup.properties > anymore by hand
Please explain that point in more detail. TBH I don't really get it how this will speed up the itests. Our itests (at least on the trunk) are based on the labs-paxexam-karaf bundles (well, the version moved to trunk) which is based on the assembly, not on anything build on the fly? *confused*. Kind regards, Andreas > - People who already know the feature concept do not have to learn the new > concept of the startup.properties > > Con: > - We have an additional description of a feature file in main. I think this > is not so bad as we keep it to the minimum. We should also detect > discrepancies very fast as the > itests will fail > > Christian > > Am 04.05.2012 19:03, schrieb Christian Schneider: > >> Hi all, >> >> on startup we currently use the following procedure. >> >> We read property karaf.auto.start from the file config.properties. >> This can be either a list of bundles separated by spaces or >> "startup.properties" or "all". >> If it is all we replace karaf.auto.start with the list of all bundles in >> the system dir. I think this option does not really make much sense. >> If it is startup.properties then we replace karaf.auto.start with the list >> of bundles specified in the file startup.properties. >> Additionally we either support mvn urls or paths which are converted to >> mvn urls. >> >> This all is quite a lot of variability of which we use none. >> >> I propose to replace this in two steps: >> >> 1. Remove the karaf.auto.start property and always load the bundles from >> startup.properties. Also only support mvn urls. >> This makes the code in main cleaner and makes it easier for our users to >> understand how to change the startup bundles. >> >> 2. Remove the startup.properties and instead use a feature name to >> determine the list of bundles to load >> The second step makes this even simpler and additionally we can remove the >> generation of the startup.properties in the karaf maven plugin. >> >> So what do you think? >> >> Christian >> > > > -- > Christian Schneider > http://www.liquid-reality.de > > Open Source Architect > Talend Application Integration Division http://www.talend.com >
