David said he didn't want xml processing in the bootstrap. This clearly has not been addressed. Andreas said there's no value in your change because the file is now fully generated. This hasn't been addressed. I said only supporting a subset of features schema is a problem. This hasn't been addressed.
I may have missed something. But when people disagree, letting time pass does not usually change things. AFAIK, those concerns has been raised on the patch you uploaded, so there's something wrong here. On Fri, May 25, 2012 at 5:30 PM, Christian Schneider <[email protected]> wrote: > I thought we had settled all these concerns. > So what are the concerns regarding the commit that make you -1 it? > > During the discussion there were some concerns but I think my implementation > should have addressed all concerns. I created an issue and put up a patch. > This was available for 4 days now. Besides you no one else took the time to > review the patch. > > So from your review you wrote you were concernd that the implementation does > not implement all features of the feature file and people might want more. > Does this really warrant a -1 ? > > Christian > > Am 25.05.2012 17:08, schrieb Guillaume Nodet: > >> Can you please revert. I think 3 people expressed concerns with the >> patch, so i'm officially -1 it until this concerns have been fully >> addressed and we've reached a consensus. >> >> On Fri, May 25, 2012 at 4:41 PM, Christian Schneider >> <[email protected]> wrote: >>> >>> I have now committed the patch. So you should be able to test from trunk >>> now. >>> >>> >>> Christian >>> >>> Am 23.05.2012 17:44, schrieb Andrei Pozolotin: >>>> >>>> Christian: >>>> >>>> >>>> I am curious >>>> >>>> 1) are your changes are in current karaf 3 snapshot? >>>> >>>> 2) do you have example/test project that shows how to build >>>> karaf distro w/o startup.properties, with minimal feature=framework >>>> only? >>>> >>>> 3) or is the idea discarded? >>>> >>>> Thank you, >>>> >>>> Andrei >>>> >>> -- >>> Christian Schneider >>> http://www.liquid-reality.de >>> >>> Open Source Architect >>> Talend Application Integration Division http://www.talend.com >>> >> >> > > > -- > Christian Schneider > http://www.liquid-reality.de > > Open Source Architect > Talend Application Integration Division http://www.talend.com > -- ------------------------ Guillaume Nodet ------------------------ Blog: http://gnodet.blogspot.com/ ------------------------ FuseSource, Integration everywhere http://fusesource.com
