Hi guys,
bin/shell currently run org.apache.karaf.shell.console.Main. It's just
the JLine implementation without the "core features". It's a tiny
container to execute command.
So IMHO, as the shell doesn't install a lot of commands (provided by
feature), but only the "core" commands (shell:*), we can perform a
System.exit without problem.
Regards
JB
On 06/17/2012 09:59 PM, Christian Schneider wrote:
I don´t know of anything that has to be cleaned up so probably we can do
System.exit.
Christian
Am 17.06.2012 21:57, schrieb Ioannis Canellos:
System.exit is of course a way to make sure you get a fast exit. The
problem is that if something is to be cleaned up in the background it
will
simply be cut off.
So the cleaner way is to not use System.exit and make sure our
background
threads terminate fast. This can be a bit tricky though :-)
Totally agree, the question is do we care if the threads are cleaned up
properlly when using bin/shell. From what I understand the purpose is to
execute commands outside OSGi, so that they can be used in scripts
etc. In
such case exiting fast seems really important.
--
Jean-Baptiste Onofré
[email protected]
http://blog.nanthrax.net
Talend - http://www.talend.com
