Basic Systemd' watchdog implementation in https://github.com/apache/karaf/pull/114, I appreciate any feedback
On Tue, Dec 1, 2015 at 4:06 PM, Jean-Baptiste Onofré <j...@nanthrax.net> wrote: > We love contribution ;) > > So we take all, populate the contrib ;) > > Thanks ! > Regards > JB > > > On 12/01/2015 03:24 PM, lb wrote: > >> Great. >> >> Another additional feature that can be easily added directly in Karaf is >> support for systemd's watchdog via jnr/jna , if anyone is interested I can >> submit a PR for this one too >> >> On Tue, Dec 1, 2015 at 3:20 PM, Fabian Lange <fabian.la...@codecentric.de >> > >> wrote: >> >> Wow indeed this is much more than my script :) Thank you for working on >>> this and especially for sharing! >>> >>> Will have a look this week >>> >>> Fabian >>> >>> On Tue, Dec 1, 2015 at 3:16 PM, lb <lburgazz...@gmail.com> wrote: >>> >>> They are a starting point, I'm sure I've missed something >>>> >>>> On Tue, Dec 1, 2015 at 3:14 PM, Jean-Baptiste Onofré <j...@nanthrax.net> >>>> wrote: >>>> >>>> Yes, please, create a Jira. >>>>> >>>>> I'm reviewing the PR. >>>>> >>>>> Thanks, >>>>> Regards >>>>> JB >>>>> >>>>> >>>>> On 12/01/2015 03:06 PM, lb wrote: >>>>> >>>>> PR sent https://github.com/apache/karaf/pull/113 >>>>>> Do you also need a JIRA ? >>>>>> >>>>>> On Tue, Dec 1, 2015 at 11:22 AM, lb <lburgazz...@gmail.com> wrote: >>>>>> >>>>>> Very simple, I had some more complex leveraging os functions like >>>>>> >>>>>>> start-stop-daemon etc, I will send a PR today so JB/ou can review >>>>>>> >>>>>>> On Tue, Dec 1, 2015 at 11:03 AM, Fabian Lange < >>>>>>> fabian.la...@codecentric.de >>>>>>> >>>>>>> wrote: >>>>>>>> >>>>>>>> >>>>>>> Maybe it was filtered because unsafe content :) >>>>>>> >>>>>>>> uploaded it to my gists: >>>>>>>> https://gist.github.com/CodingFabian/90d46cfdce0085ee004c >>>>>>>> >>>>>>>> Fabian >>>>>>>> >>>>>>>> On Tue, Dec 1, 2015 at 11:01 AM, lb <lburgazz...@gmail.com> wrote: >>>>>>>> >>>>>>>> Hi Fabian, >>>>>>>> >>>>>>>>> I do not see the attachment >>>>>>>>> >>>>>>>>> On Tue, Dec 1, 2015 at 10:27 AM, Fabian Lange < >>>>>>>>> >>>>>>>>> fabian.la...@codecentric.de >>>>>>>> >>>>>>>> >>>>>>>>> wrote: >>>>>>>>>> >>>>>>>>> >>>>>>>>> Hi Luca, >>>>>>>>> >>>>>>>>>> >>>>>>>>>> I am using the attached script on some systems, which is obviously >>>>>>>>>> >>>>>>>>>> very >>>>>>>>> >>>>>>>> >>>>>>>> simple but it works. The problem with upstart is that somehow the >>>>>>>>> >>>>>>>> PID >>> >>>> tracking does neither work with normal nor fork mode. I have not >>>>>>>>>> >>>>>>>>>> narrowed >>>>>>>>> >>>>>>>> >>>>>>>> it down yet. >>>>>>>>> >>>>>>>>>> >>>>>>>>>> Fabian >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> On Tue, Dec 1, 2015 at 10:21 AM, lb <lburgazz...@gmail.com> >>>>>>>>>> >>>>>>>>> wrote: >>> >>>> >>>>>>>>>> Hi Fabian, JB, >>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> beside my attempt to migrate the wrapper from Tanuki to YAJSW, >>>>>>>>>>> >>>>>>>>>> I'm >>> >>>> >>>>>>>>>>> also >>>>>>>>>> >>>>>>>>> >>>>>>>> working on a set of scripts for systemd, init.d, solaris smf and >>>>>>>>> >>>>>>>>>> >>>>>>>>>>> windows >>>>>>>>>> >>>>>>>>> >>>>>>>> to >>>>>>>>> >>>>>>>>>> start karaf without the wrapper so I think it would be nice to >>>>>>>>>>> >>>>>>>>>>> collect >>>>>>>>>> >>>>>>>>> >>>>>>>> requirement, attention points and so on in a JIRA and provides such >>>>>>>>> >>>>>>>>>> templates in karaf distribution (i.e. in docs/contrib/scripts). >>>>>>>>>>> >>>>>>>>>>> What do you think ? >>>>>>>>>>> >>>>>>>>>>> Regards, >>>>>>>>>>> Luca >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> On Mon, Nov 30, 2015 at 11:03 AM, Jean-Baptiste Onofré < >>>>>>>>>>> >>>>>>>>>>> j...@nanthrax.net >>>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>>>> wrote: >>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> Hi Fabian, >>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> I added systemd support in JSW wrapper. >>>>>>>>>>>> >>>>>>>>>>>> I don't see any blocker to use start/stop/status scripts in >>>>>>>>>>>> >>>>>>>>>>> systemd >>>> >>>>> >>>>>>>>>>>> (or >>>>>>>>>>> >>>>>>>>>> >>>>>>>>> SystemV). Of course, we can improve those scripts to have a better >>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>>> usage >>>>>>>>>>> >>>>>>>>>> >>>>>>>>> via systemd. Please, if you can describe the improvements in a >>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>>> Jira, I >>>>>>>>>>> >>>>>>>>>> >>>>>>>> will >>>>>>>>> >>>>>>>>>> >>>>>>>>>>> enhance it. >>>>>>>>>>>> >>>>>>>>>>>> Thanks, >>>>>>>>>>>> Regards >>>>>>>>>>>> JB >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> On 11/30/2015 10:56 AM, Fabian Lange wrote: >>>>>>>>>>>> >>>>>>>>>>>> Hi, >>>>>>>>>>>> >>>>>>>>>>>>> I know that there is extensive support in Karaf for using >>>>>>>>>>>>> >>>>>>>>>>>> Tanuki >>> >>>> >>>>>>>>>>>>> to >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>> install >>>>>>>>> >>>>>>>>>> Karaf as service. >>>>>>>>>>>>> >>>>>>>>>>>>> I have received however comments that it is difficult to use >>>>>>>>>>>>> >>>>>>>>>>>> the >>> >>>> >>>>>>>>>>>>> existing >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> scripts: >>>>>>>>>>>> >>>>>>>>>>>>> start/stop/status >>>>>>>>>>>>> >>>>>>>>>>>>> in an upstart or systemd manner. >>>>>>>>>>>>> As far As i can tell one of the problems is how Karaf handles >>>>>>>>>>>>> >>>>>>>>>>>>> PIDs. >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>> >>>>>>>>> Does anybody have working scripts? Or can we improve here to >>>>>>>>>>>>> >>>>>>>>>>>> make >>> >>>> >>>>>>>>>>>>> this >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>> an >>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> option besides Tanuki? >>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> Best regards, >>>>>>>>>>>>> Fabian >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> -- >>>>>>>>>>>>> >>>>>>>>>>>> Jean-Baptiste Onofré >>>>>>>>>>>> jbono...@apache.org >>>>>>>>>>>> http://blog.nanthrax.net >>>>>>>>>>>> Talend - http://www.talend.com >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>> >>>>>>> >>>>>> -- >>>>> Jean-Baptiste Onofré >>>>> jbono...@apache.org >>>>> http://blog.nanthrax.net >>>>> Talend - http://www.talend.com >>>>> >>>>> >>>> >>> >> > -- > Jean-Baptiste Onofré > jbono...@apache.org > http://blog.nanthrax.net > Talend - http://www.talend.com >
