+1 for releasing quickly. I think most people will take the examples from master anyway.
Christian 2017-01-30 21:57 GMT+01:00 Jean-Baptiste Onofré <[email protected]>: > Let me go back to the commit before removing OSGi examples. > > We can provide simple OSGi (with Config), Blueprint, DS, Branding and move > demos in examples pretty quickly, included in the distribution. > > As I would like to release 4.1.0 asap, I propose to start the merge on the > examples on master after the release. People can always take a look on the > examples and they will be shipped in 4.1.1 release. > As said, I don't want to hold 4.1.0 any longer (I'm already releasing Pax > Exam 4.10.0 as it's required for 4.1.0). > > Regards > JB > > > On 01/30/2017 09:40 PM, Achim Nierbeck wrote: > >> As I'm with Krzysztof it's sometimes hard to find good plain OSGi samples, >> I'd keep those. >> Still nowadays plain OSGi is actually rather advanced. Therefore a >> "starter" sample should start with DS, instead of plain OSGi. >> >> Besides this, why not start with some examples now and publish the full >> set >> with Karaf 4.1.1?? >> >> regards, Achim >> >> >> 2017-01-30 21:23 GMT+01:00 Jean-Baptiste Onofré <[email protected]>: >> >> Thanks for your feedback Krzysztof. >>> >>> I share your thoughts. Christian comment was more to put the beginners on >>> the right track as soon as they start. >>> >>> I'm in favor of keeping OSGi samples (including config) as well. >>> >>> Let's see what the others will think. >>> >>> Regards >>> JB >>> >>> >>> On 01/30/2017 09:18 PM, Krzysztof Sobkowiak wrote: >>> >>> I like the new examples. They will be a good starter for people who want >>>> to start using Karaf. >>>> Personally I would keep the plain OSGi samples (maybe with a comment >>>> this >>>> is a more advanced stuff or moving them to a section with advanced >>>> examples). >>>> I was often looking for a good sample how to do something good in plain >>>> OSGI. It would be good to have them in Karaf examples >>>> >>>> Kindly regards >>>> Krzysztof >>>> >>>> On 30.01.2017 19:14, Jean-Baptiste Onofré wrote: >>>> >>>> I started to do the changes proposed by Christian, and Christian also >>>>> kindly offered his help to update the examples. >>>>> >>>>> As I don't want to hold the 4.1.0 longer, I'm postponing the examples >>>>> in >>>>> the distribution for 4.1.1 release. As examples can be the key part to >>>>> start with Karaf, it makes sense to take time to polish a bit and >>>>> provide a >>>>> complete overview. >>>>> >>>>> So, I moved KARAF-2511 (related to the examples in the distribution) to >>>>> Karaf 4.1.1 release and I'm starting 4.1.0 release. >>>>> >>>>> Sorry again for the noise (just wanted to keep you posted about the >>>>> last >>>>> progress). >>>>> >>>>> Stay tuned tonight for the release vote e-mail. >>>>> >>>>> Thanks ! >>>>> Regards >>>>> JB >>>>> >>>>> On 01/30/2017 03:12 PM, Christian Schneider wrote: >>>>> >>>>> Like discussed on IRC. >>>>>> >>>>>> The examples should be named sample or examples instead of starter. >>>>>> Starter would be confused with the spring boot meaning of starter. >>>>>> The blueprint and jpa examples are good. >>>>>> >>>>>> I would leave out the plain OSGi examples. For anything more complex >>>>>> the >>>>>> OSGi API is too difficult to use and leads beginners on the wrong >>>>>> track. >>>>>> Instead of the OSGi examples I propose to prepare DS examples and add >>>>>> them to the next karaf release. >>>>>> >>>>>> Christian >>>>>> >>>>>> On 30.01.2017 14:41, Jean-Baptiste Onofré wrote: >>>>>> >>>>>> Agree for the examples in the distribution as well ? >>>>>>> >>>>>>> Regards >>>>>>> JB >>>>>>> >>>>>>> On 01/30/2017 02:37 PM, Christian Schneider wrote: >>>>>>> >>>>>>> I also think a 4.1.0 should be ok with the current status. >>>>>>>> >>>>>>>> We just need to document that some features like activemq might need >>>>>>>> the >>>>>>>> spring or enterprise legacy repos. >>>>>>>> >>>>>>>> Christian >>>>>>>> >>>>>>>> On 30.01.2017 13:39, Jean-Baptiste Onofré wrote: >>>>>>>> >>>>>>>> Hi, >>>>>>>>> >>>>>>>>> I confirm the "jline" commands are now working fine. >>>>>>>>> >>>>>>>>> So, I will release 4.1.0. >>>>>>>>> >>>>>>>>> As part of the 4.1.0, I would like to include examples (I have some >>>>>>>>> more in preparation that I gonna merge) in the standard >>>>>>>>> distribution: >>>>>>>>> >>>>>>>>> https://github.com/jbonofre/karaf/tree/DEV_GUIDE/examples >>>>>>>>> >>>>>>>>> We will improve and extend the examples (and dev guide) for 4.1.1. >>>>>>>>> >>>>>>>>> WDYT ? >>>>>>>>> >>>>>>>>> Regards >>>>>>>>> JB >>>>>>>>> >>>>>>>>> On 01/30/2017 11:05 AM, Jean-Baptiste Onofré wrote: >>>>>>>>> >>>>>>>>> Hi all, >>>>>>>>>> >>>>>>>>>> Guillaume fixed the shell backward compatibility this morning. >>>>>>>>>> >>>>>>>>>> I'm testing the fix now and if it's good, I will directly do a >>>>>>>>>> 4.1.0 >>>>>>>>>> release. >>>>>>>>>> >>>>>>>>>> Thanks ! >>>>>>>>>> Regards >>>>>>>>>> JB >>>>>>>>>> >>>>>>>>>> On 01/29/2017 01:38 PM, Jean-Baptiste Onofré wrote: >>>>>>>>>> >>>>>>>>>> A quick new update related to the first Karaf 4.1.x release. >>>>>>>>>>> >>>>>>>>>>> 1. Jenkins build >>>>>>>>>>> I fixed the Jenkins jobs for both master and karaf-4.0.x: >>>>>>>>>>> >>>>>>>>>>> https://builds.apache.org/view/K/view/Karaf/ >>>>>>>>>>> >>>>>>>>>>> I also removed the job for karaf-3.0.x. >>>>>>>>>>> >>>>>>>>>>> The build are now fully OK, including itests. >>>>>>>>>>> It's important to keep this build clean. I encourage you to check >>>>>>>>>>> the >>>>>>>>>>> result of the build after your commits. If you have any doubt >>>>>>>>>>> before >>>>>>>>>>> committing, we still have the PR validation job. So, you can >>>>>>>>>>> create a >>>>>>>>>>> pull request that will be validated by Jenkins. Then, you can >>>>>>>>>>> merge >>>>>>>>>>> your >>>>>>>>>>> PR branch. >>>>>>>>>>> >>>>>>>>>>> 2. Shell command issue >>>>>>>>>>> Several projects providing shell commands (like Camel, ActiveMQ, >>>>>>>>>>> ...) >>>>>>>>>>> directly use jline dependency. It's pretty bad (they should use >>>>>>>>>>> the >>>>>>>>>>> Karaf "wrapper), and, as Karaf 4.1.x now uses JLine 3.x, those >>>>>>>>>>> commands >>>>>>>>>>> don't work in Karaf 4.1.x. >>>>>>>>>>> Here, we have two solutions: >>>>>>>>>>> 2.1. We create the jline "2.x" compliant packages in Karaf (in a >>>>>>>>>>> bundle >>>>>>>>>>> as part of the shell-compat feature for instance). It's only a >>>>>>>>>>> workaround but should fix the issue. >>>>>>>>>>> 2.2. jline 3.x can provide a "compat" bundle with the jline 2.x >>>>>>>>>>> packages >>>>>>>>>>> name, wrapping the jline 3.x ones. It's probably the most elegant >>>>>>>>>>> solution, but it's require a new jline 3.x release. >>>>>>>>>>> >>>>>>>>>>> 3. Version & Schedule >>>>>>>>>>> Basically, I planned to release 4.1.0-M1 version today, as shell >>>>>>>>>>> command >>>>>>>>>>> "break" is pretty bad. I'm postponing the decision to tomorrow >>>>>>>>>>> evening. >>>>>>>>>>> I plan to discuss with Guillaume tomorrow about the jline 3 and >>>>>>>>>>> shell >>>>>>>>>>> commands issue. If we can find a good solution, and release jline >>>>>>>>>>> 3.1.3 >>>>>>>>>>> tomorrow, then, I will release Karaf 4.1.0 tomorrow evening. >>>>>>>>>>> If it's more complex and requires more time, then, I will release >>>>>>>>>>> 4.1.0-M1 tomorrow evening, the 4.1.0 (GA) will be released 3 >>>>>>>>>>> weeks >>>>>>>>>>> later, giving time for us to fix the jline/command issue. >>>>>>>>>>> >>>>>>>>>>> Thanks ! >>>>>>>>>>> Regards >>>>>>>>>>> JB >>>>>>>>>>> >>>>>>>>>>> On 01/29/2017 11:31 AM, Jean-Baptiste Onofré wrote: >>>>>>>>>>> >>>>>>>>>>> Hi all, >>>>>>>>>>>> >>>>>>>>>>>> the problem is clearly an incompatible version of jline >>>>>>>>>>>> (resulting of >>>>>>>>>>>> the update we did in Karaf 4.1.x). It breaks other projects >>>>>>>>>>>> which >>>>>>>>>>>> are >>>>>>>>>>>> using directly jline (for completer for instance). >>>>>>>>>>>> >>>>>>>>>>>> So, the other projects should be refactored (camel, activemq, >>>>>>>>>>>> ...) to >>>>>>>>>>>> not relay on jline but Karaf (for the completer for instance). >>>>>>>>>>>> >>>>>>>>>>>> Anyway, it means that Karaf 4.1.0 is not yet ready to support >>>>>>>>>>>> any >>>>>>>>>>>> other >>>>>>>>>>>> projects. >>>>>>>>>>>> >>>>>>>>>>>> So, I'm going to 4.1.0-M1 first and we will invite maximum of >>>>>>>>>>>> people to >>>>>>>>>>>> test on this milestone in order to clearly identify the breaking >>>>>>>>>>>> changes >>>>>>>>>>>> and provide max backward compatibility when possible. >>>>>>>>>>>> >>>>>>>>>>>> I already changed the version in Jira and I will cut 4.1.0-M1 >>>>>>>>>>>> later >>>>>>>>>>>> today. >>>>>>>>>>>> >>>>>>>>>>>> Regards >>>>>>>>>>>> JB >>>>>>>>>>>> >>>>>>>>>>>> On 01/28/2017 03:32 PM, Jean-Baptiste Onofré wrote: >>>>>>>>>>>> >>>>>>>>>>>> Hi guys, >>>>>>>>>>>>> >>>>>>>>>>>>> as you might know, I'm preparing the Karaf 4.1.0 release. >>>>>>>>>>>>> >>>>>>>>>>>>> We are mostly ok, but during my tests, I found that Camel (at >>>>>>>>>>>>> least >>>>>>>>>>>>> 2.18.1) commands are not available in the shell. >>>>>>>>>>>>> >>>>>>>>>>>>> I suspect because they use the "old" style. >>>>>>>>>>>>> >>>>>>>>>>>>> I also see lot of small annoying behaviors in the shell console >>>>>>>>>>>>> (on >>>>>>>>>>>>> completion especially). >>>>>>>>>>>>> >>>>>>>>>>>>> So, even we are mostly ready, I'm not sure it's fully ready for >>>>>>>>>>>>> production. >>>>>>>>>>>>> >>>>>>>>>>>>> Instead of directly releasing Karaf 4.1.0, I propose to release >>>>>>>>>>>>> 4.1.0-M1 >>>>>>>>>>>>> as a tech preview. I would allow people to review and test >>>>>>>>>>>>> 4.1.0-M1 but >>>>>>>>>>>>> give a good message that's a tech preview. >>>>>>>>>>>>> >>>>>>>>>>>>> WDYT ? >>>>>>>>>>>>> >>>>>>>>>>>>> Regards >>>>>>>>>>>>> JB >>>>>>>>>>>>> >>>>>>>>>>>>> On 01/05/2017 03:39 PM, Jean-Baptiste Onofré wrote: >>>>>>>>>>>>> >>>>>>>>>>>>> Hi guys, >>>>>>>>>>>>>> >>>>>>>>>>>>>> I started the updates and fixes for Karaf 4.1.0. >>>>>>>>>>>>>> >>>>>>>>>>>>>> As dependencies, we will need Pax Exam 4.10.0 and Pax Web >>>>>>>>>>>>>> 6.0.1. >>>>>>>>>>>>>> Achim >>>>>>>>>>>>>> and I will tackle this as it's pre-requisite for 4.1.0. >>>>>>>>>>>>>> >>>>>>>>>>>>>> I plan to create karaf-4.1.x branch next week for a release >>>>>>>>>>>>>> the >>>>>>>>>>>>>> following week. >>>>>>>>>>>>>> >>>>>>>>>>>>>> Thoughts ? >>>>>>>>>>>>>> >>>>>>>>>>>>>> Thanks, >>>>>>>>>>>>>> Regards >>>>>>>>>>>>>> JB >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>> >>>>>> >>>>>> >>>>> >>>> -- >>> Jean-Baptiste Onofré >>> [email protected] >>> http://blog.nanthrax.net >>> Talend - http://www.talend.com >>> >>> >> >> >> > -- > Jean-Baptiste Onofré > [email protected] > http://blog.nanthrax.net > Talend - http://www.talend.com > -- -- Christian Schneider http://www.liquid-reality.de <https://owa.talend.com/owa/redir.aspx?C=3aa4083e0c744ae1ba52bd062c5a7e46&URL=http%3a%2f%2fwww.liquid-reality.de> Open Source Architect http://www.talend.com <https://owa.talend.com/owa/redir.aspx?C=3aa4083e0c744ae1ba52bd062c5a7e46&URL=http%3a%2f%2fwww.talend.com>
