+1

We have the same for some other commands. For instance shell:watch has an implementation in Karaf but also in jline. I would also propose to keep only the jline commands.

Regards
JB

On 10/04/2017 11:02 AM, Guillaume Nodet wrote:
I'm working on KARAF-4785
<https://issues.apache.org/jira/browse/KARAF-4785> and
I've already fixed the completion of the native scr commands.  This means
that we'll have some kind of duplication of all scr commands.  Kind of,
because even though they are similar, the output is different.  The native
commands provide a deeper view of the SCR components.

So, should I go ahead and just remove the Karaf specific commands ?

Below is the output of the native commands and then the karaf commands...

Cheers,
Guillaume

*karaf*@root()> scr:list

  BundleId Component Name Default State

     Component Id State      PIDs (Factory PID)

  [  38]   ScrServiceMBean  enabled

     [   4] [active      ]

  [ 145]   org.ops4j.pax.web.deployer.internal.WarDeployer  enabled

     [   3] [active      ]

  [ 151]   org.ops4j.pax.web.service.internal.WhiteboardDtoService  enabled

     [   5] [active      ]

*karaf*@root()> scr:info org.ops4j.pax.web.deployer.internal.WarDeployer



*** Bundle: org.ops4j.pax.web.pax-web-deployer (145)

Component Description:

   Name: org.ops4j.pax.web.deployer.internal.WarDeployer

   Implementation Class: org.ops4j.pax.web.deployer.internal.WarDeployer

   Default State: enabled

   Activation: delayed

   Configuration Policy: optional

   Activate Method: activate

   Deactivate Method: deactivate

   Modified Method: -

   Configuration Pid: [org.ops4j.pax.web.deployer.internal.WarDeployer]

   Services:

     org.apache.felix.fileinstall.ArtifactUrlTransformer

   Service Scope: singleton

   Component Description Properties:

   Component Configuration:

     ComponentId: 3

     State: active

     Component Configuration Properties:

         component.id = 3

         component.name = org.ops4j.pax.web.deployer.internal.WarDeployer


*karaf*@root()> scr:components

ID │ State  │ Component Name

───┼────────┼────────────────────────────────────────────────────────

3  │ ACTIVE │ org.ops4j.pax.web.deployer.internal.WarDeployer

5  │ ACTIVE │ org.ops4j.pax.web.service.internal.WhiteboardDtoService

*karaf*@root()> scr:details org.ops4j.pax.web.deployer.internal.WarDeployer

*Component Details*

*  Name                : *org.ops4j.pax.web.deployer.internal.WarDeployer

*  State               : *ACTIVE

*References*

*karaf*@root()>





--
Jean-Baptiste Onofré
jbono...@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com

Reply via email to