Hi JB, It's good for me, I think we could apply it now.
regards, François Papon [email protected] Le 23/11/2018 à 09:19, Jean-Baptiste Onofré a écrit : > Hi guys, > > Thoughts about spotless ? > > https://github.com/apache/karaf/pull/648 > > I will update the PR today. > > Agree to apply spotless or we just avoid this for now ? Shall I start a > formal vote ? > > Thanks ! > Regards > JB > > On 07/11/2018 05:43, Jean-Baptiste Onofré wrote: >> Hi team, >> >> I created a PR (https://github.com/apache/karaf/pull/648) to enable >> spotless in Karaf. >> >> Spotless is code style checker but also formatter. >> >> The spotless profile I added in the PR check the style and the style can >> be automatically fixed using mvn spotless:apply -Pspotless. >> >> I think it would be great to have this in Karaf and subprojects to have >> a consistency in our code style. >> >> In combination with rat, it gives us a much cleaner code. >> >> On the other hand, I was planning to add findbugs maven plugin as well. >> >> Thoughts ? >> >> Thanks, >> Regards >> JB >>
