Hi Justin

Thanks for the review. I gonna fix that for next releases. 

Regards 
JB

> Le 9 juin 2021 à 05:22, Justin Mclean <[email protected]> a écrit :
> 
> Hi,
> 
> I'm not on your PMC but I took a look at your source release and noticed a 
> couple of issues that you may want to look into:
> - It's missing a NOTICE file
> - Your license file doesn't mention any 3rd party software that is included 
> in the release e.g. [3][4][5][6][8][9][10] and others
> - The source release contains compiled code e.g. [1][2][12][13][14]
> - Some file have an ASF copyright in their header  e.g [11] and others
> 
> Kind Regards,
> Justin
> 
> 1. ./wrapper/src/main/resources/org/apache/karaf/wrapper/internal/*
> 2. ./deployer/kar/src/test/resources/goodKarFile.kar
> 3. 
> ./profile/src/main/java/org/apache/karaf/profile/command/ProfileChangeParents.java
> 4. 
> ./webconsole/instance/src/main/java/org/apache/karaf/webconsole/instance/InstancePlugin.java
> 5 ./shell/console/src/main/java/jline/internal/Preconditions.java
> 6. ./shell/console/src/main/java/jline/console/completer/Completer.java
> 7 ./shell/console/src/main/java/jline/console/completer/StringsCompleter.java
> 8 ./specs/java.xml/src/main/java/org/w3c/dom/ElementTraversal.java
> 9 
> ./shell/core/src/main/java/org/apache/karaf/shell/support/converter/ReifiedType.java
> 10. ./util/src/main/java/org/apache/karaf/util/maven/Parser.java
> 11. 
> ./webconsole/http/src/main/java/org/apache/karaf/webconsole/http/ServletDetails.java
> 12. 
> ./main/src/test/resources/test-karaf-home/system/org/apache/felix/org.apache.felix.framework/5.6.10/org.apache.felix.framework-5.6.10.jar
> 13. 
> ./main/src/test/resources/test-karaf-home/system/org/apache/aries/blueprint/org.apache.aries.blueprint.api/1.0.0/org.apache.aries.blueprint.api-1.0.0.jar
> 14. ./main/src/test/resources/test-karaf-home/system/pax-url-mvn.jar

Reply via email to