jbonofre commented on code in PR #78: URL: https://github.com/apache/karaf-site/pull/78#discussion_r4026880909
########## README.md: ########## @@ -48,6 +48,8 @@ npm run watch:css # rebuild CSS continuously while styling npm run optimize:svg # minify the SVG assets (logos) after editing any images/*.svg ``` +`assets/css/karaf.css` is committed to the repository, not gitignored: the production deploy below only runs `bundle exec jekyll build`, which cannot resolve the Bootstrap 5 Sass imports in `_scss/` (that requires `node_modules` via the `sass` CLI). Whenever you change anything under `_scss/`, run `npm run build:css` and commit the regenerated `assets/css/karaf.css` together with your source change. Review Comment: Fair, let me instruct. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
