turbaszek commented on a change in pull request #8: URL: https://github.com/apache/kibble/pull/8#discussion_r641906748
########## File path: kibble/scanners/base.py ########## @@ -0,0 +1,31 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +import logging +from typing import Any + + +class BaseScanner: + """Abstract, base class for all scanners""" + + # pylint: disable=too-few-public-methods + def __init__(self, **kwargs): + self.log = logging.getLogger(__name__) + + def _persist(self, payload: Any): # pylint: disable=no-self-use + """Persists data to database. Should be implemented per scanner.""" Review comment: > One scanner, one database/table? I assume there will be only one database with multiple collections / document types. Need to evaluate ES vs some other nosql db. But general idea here is that each data type provides information how to persist it and how to read it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
