I think I was able to run the action without the third-party modules. It should be working now. Thanks Jan, for the early review. We can continue after merging this PR and having the build-chain whitelisted.
Cheers! -- Ricardo Zanini Fernandes Vida longa e próspera. On Wed, Oct 4, 2023 at 3:41 PM ricardo zanini fernandes < [email protected]> wrote: > Here you go: > https://github.com/apache/incubator-kie-kogito-pipelines/pull/1104 > > I'll run a few tests on my fork to make sure this will work. > > -- > Ricardo Zanini Fernandes > Vida longa e próspera. > > > On Wed, Oct 4, 2023 at 3:03 PM ricardo zanini fernandes < > [email protected]> wrote: > >> Sure thing! >> >> Here's the ticket: https://issues.apache.org/jira/browse/INFRA-25050 >> >> I'm migrating the other modules depending on Maven, and should have a PR >> soon. >> >> Cheers! >> -- >> Ricardo Zanini Fernandes >> Vida longa e próspera. >> >> >> On Wed, Oct 4, 2023 at 3:02 PM Alex Porcelli <[email protected]> wrote: >> >>> Ricardo, >>> >>> I completely get the value of the mentioned repo for the current >>> situation we have (several repositories, with complex chain of >>> dependencies), I just don't think the current situation is sustainable >>> for the long term based on the new reality of Apache. >>> >>> However, as you properly mentioned, right now the focus is to migrate >>> as is... and let's start new discussions only after we complete it :) >>> >>> On Wed, Oct 4, 2023 at 1:57 PM ricardo zanini fernandes >>> <[email protected]> wrote: >>> > >>> > Alex, >>> > >>> > I'll open a ticket, but I'm curious why you're saying that this repo >>> does >>> > not have much to do with KIE since this action is used among all our >>> > projects to run the builds. >>> > I'm okay having it whitelisted now, thou. Let's talk about renovating >>> the >>> > CI once we wrap up this migration. >>> > >>> > Cheers! >>> > -- >>> > Ricardo Zanini Fernandes >>> > Vida longa e próspera. >>> > >>> > >>> > On Wed, Oct 4, 2023 at 2:06 PM Alex Porcelli <[email protected]> wrote: >>> > >>> > > Ricardo, >>> > > >>> > > I share similar concerns as Tibor for the proposed repository, so >>> > > probably the best thing is to start a new focused PROPOSAL thread to >>> > > discuss. >>> > > >>> > > On Wed, Oct 4, 2023 at 12:50 PM Tibor Zimányi < >>> [email protected]> >>> > > wrote: >>> > > > >>> > > > Hi Ricardo, >>> > > > >>> > > > I would recommend, that you can ask for the exception, till we get >>> an >>> > > > agreement about the repository itself. >>> > > > >>> > > > Best regards, >>> > > > Tibor >>> > > > >>> > > > Dňa st 4. 10. 2023, 18:35 ricardo zanini fernandes < >>> > > [email protected]> >>> > > > napísal(a): >>> > > > >>> > > > > Tibor, >>> > > > > >>> > > > > This action, AFAIK, is highly related to our repos, so I think we >>> > > should >>> > > > > consider moving and maintaining it. Another option is to >>> whitelist it >>> > > for >>> > > > > now, but open tickets to migrate/review the whole pipeline in the >>> > > future. >>> > > > > Can we get a consensus from the community on what we can do now? >>> Sorry >>> > > to >>> > > > > sound too pushy, but I really want to move forward since we need >>> to >>> > > start >>> > > > > merging PRs, and without a working CI we can't. :( >>> > > > > >>> > > > > Cheers! >>> > > > > -- >>> > > > > Ricardo Zanini Fernandes >>> > > > > Vida longa e próspera. >>> > > > > >>> > > > > >>> > > > > On Wed, Oct 4, 2023 at 12:13 PM Tibor Zimányi < >>> [email protected] >>> > > > >>> > > > > wrote: >>> > > > > >>> > > > > > Hi Ricardo, >>> > > > > > >>> > > > > > I don't think it is necessary to move that, you can create an >>> INFRA >>> > > > > ticket, >>> > > > > > similar to this one, to whitelist the action: >>> > > > > > https://issues.apache.org/jira/browse/INFRA-24928. In my >>> personal >>> > > > > opinion, >>> > > > > > the code in the repository has not much to do with the KIE >>> community >>> > > > > domain >>> > > > > > and it will be another task to maintain it. However that is my >>> > > opinion, >>> > > > > if >>> > > > > > there is a broad agreement to migrate it, I am not against it. >>> > > > > > >>> > > > > > "Was this kind of work assessed before the migration?" - This >>> was >>> > > > > assessed >>> > > > > > as best as we could do at the time as we didn't know exactly >>> what, >>> > > and >>> > > > > more >>> > > > > > importantly in which form (GitHub Actions and GitHub Actions >>> in other >>> > > > > > organizations can be different - as you actually experienced, >>> same >>> > > with >>> > > > > > Jenkins - you can have a different plugins set installed), is >>> > > available >>> > > > > in >>> > > > > > Apache. Migrating a community that has over 100 various >>> repositories >>> > > is >>> > > > > > very hard to assess up front. The migration was planned for >>> multiple >>> > > > > months >>> > > > > > ahead, with multiple information streams about it, and all >>> help from >>> > > > > people >>> > > > > > in the community to get this migration done is very >>> appreciated. >>> > > > > > >>> > > > > > Best regards, >>> > > > > > Tibor >>> > > > > > >>> > > > > > On Wed, Oct 4, 2023 at 4:45 PM ricardo zanini fernandes < >>> > > > > > [email protected]> wrote: >>> > > > > > >>> > > > > > > Jan/Tibor >>> > > > > > > >>> > > > > > > Can we migrate this action to Apache? >>> > > > > > > https://github.com/kiegroup/github-action-build-chain/ >>> > > > > > > >>> > > > > > > We are using it in our runs, and I believe that based on >>> Apache >>> > > policy >>> > > > > > [1], >>> > > > > > > we won't be able to use it. It's a quite complex action and >>> it >>> > > would >>> > > > > > > be tremendous work to migrate everything otherwise. >>> > > > > > > >>> > > > > > > Was this kind of work assessed before the migration? >>> > > > > > > >>> > > > > > > [1] Actions in this workflow must be: *within a repository >>> owned by >>> > > > > > > apache*, >>> > > > > > > created by GitHub, verified in the GitHub Marketplace, or >>> matching >>> > > the >>> > > > > > > following: [..] >>> > > > > > > >>> > > > > > > Cheers! >>> > > > > > > -- >>> > > > > > > Ricardo Zanini Fernandes >>> > > > > > > Vida longa e próspera. >>> > > > > > > >>> > > > > > > >>> > > > > > > On Tue, Oct 3, 2023 at 3:31 PM ricardo zanini fernandes < >>> > > > > > > [email protected]> wrote: >>> > > > > > > >>> > > > > > > > Jan, >>> > > > > > > > >>> > > > > > > > I think I can make more use of my time taking a look at >>> GHA PR >>> > > > > checks. >>> > > > > > > > I'll start working on it! Thanks for the detailed report! >>> > > > > > > > >>> > > > > > > > Cheers! >>> > > > > > > > -- >>> > > > > > > > Ricardo Zanini Fernandes >>> > > > > > > > Vida longa e próspera. >>> > > > > > > > >>> > > > > > > > >>> > > > > > > > On Tue, Oct 3, 2023 at 3:25 PM Jan Šťastný < >>> > > [email protected]> >>> > > > > > > wrote: >>> > > > > > > > >>> > > > > > > >> Hello Ricardo, >>> > > > > > > >> not sure if you're checking the other thread where I >>> report >>> > > > > progress. >>> > > > > > > I'll >>> > > > > > > >> try to summarize where you could jump in at the moment and >>> > > justify >>> > > > > why >>> > > > > > > >> everything is taking so long. >>> > > > > > > >> >>> > > > > > > >> 1. We don't release nightly SNAPSHOTS at the moment. >>> There's >>> > > several >>> > > > > > > steps >>> > > > > > > >> leading to it, including moving projects from >>> jboss-parent to >>> > > apache >>> > > > > > > one, >>> > > > > > > >> fixing trigger issue in CI (should be fine when merged) >>> and I >>> > > > > suspect >>> > > > > > > >> we'll >>> > > > > > > >> hit a few more as we go. Then we can onboard to Apache >>> nexus and >>> > > > > start >>> > > > > > > >> having snapshots release, which would simplify the rest of >>> > > things >>> > > > > > quite >>> > > > > > > a >>> > > > > > > >> bit. >>> > > > > > > >> 2. For that reason, all builds need to build full the >>> chain - a >>> > > > > > > >> kogito-examples PR need to start build from drools, so >>> that >>> > > > > artifacts >>> > > > > > > are >>> > > > > > > >> installed, etc. We're using build-chain tool for that. >>> The tool >>> > > has >>> > > > > > > >> significant issue at the moment (identified just today), >>> we're >>> > > > > looking >>> > > > > > > to >>> > > > > > > >> fix it in kiegroup/github-action-build-chain/issues/461 . >>> > > > > > > >> 3. GitHub Actions, not being completely separate from >>> these >>> > > efforts, >>> > > > > > > need >>> > > > > > > >> to follow the same path at the moment I am afraid - no >>> > > snapshots, it >>> > > > > > > needs >>> > > > > > > >> to be a Full downstream build. >>> > > > > > > >> >>> > > > > > > >> I am currently taking care of getting initial PR checks in >>> > > Jenkins >>> > > > > to >>> > > > > > > run >>> > > > > > > >> reliably (although way too long, I understand) and prepare >>> > > nightly >>> > > > > > > >> pipeline >>> > > > > > > >> builds including triggers. >>> > > > > > > >> >>> > > > > > > >> Tibor is working on moving the repositories from >>> jboss-parent to >>> > > > > > Apache >>> > > > > > > >> one, being a prerequisite for Apache nexus onboarding. >>> > > > > > > >> >>> > > > > > > >> Your area of focus could be getting GHA, just consider >>> all that >>> > > was >>> > > > > > > said - >>> > > > > > > >> before we have snapshots, we can't limit the scope of the >>> build >>> > > .... >>> > > > > > and >>> > > > > > > >> so >>> > > > > > > >> on. >>> > > > > > > >> Another area would be the Apache nexus onboarding itself >>> - if >>> > > it can >>> > > > > > be >>> > > > > > > >> initiated already, etc, you can check >>> > > > > > > >> https://infra.apache.org/publishing-maven-artifacts.html. >>> > > > > > > >> >>> > > > > > > >> Regards >>> > > > > > > >> Jan >>> > > > > > > >> >>> > > > > > > >> >>> > > > > > > >> >>> > > > > > > >> >>> > > > > > > >> On Tue, 3 Oct 2023 at 19:57, ricardo zanini fernandes < >>> > > > > > > >> [email protected]> wrote: >>> > > > > > > >> >>> > > > > > > >> > Hey folks! >>> > > > > > > >> > >>> > > > > > > >> > As you may know, since the migration, the PR checks are >>> not >>> > > been >>> > > > > > > >> running. >>> > > > > > > >> > So we are kind of blocked from merging anything based >>> on our >>> > > > > policy. >>> > > > > > > >> > >>> > > > > > > >> > I intend to take a few hours to work on it. I'll try to >>> make >>> > > this >>> > > > > > work >>> > > > > > > >> at >>> > > > > > > >> > least for kogito-runtimes to unlock the community: >>> > > > > > > >> > >>> > > > > > > >> > >>> > > > > > > >> > >>> > > > > > > >> >>> > > > > > > >>> > > > > > >>> > > > > >>> > > >>> https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/view/change-requests/ >>> > > > > > > >> > >>> > > > > > > >> > After that, I'll take a look at GHA. I assume we will >>> have to >>> > > > > > migrate >>> > > > > > > >> many >>> > > > > > > >> > actions to our own org or to shell scripts or try to do >>> > > something >>> > > > > > > >> entirely >>> > > > > > > >> > different. But that's a topic for the future. >>> > > > > > > >> > >>> > > > > > > >> > That's been said, Jan and Tibor, can you please share >>> any >>> > > useful >>> > > > > > > >> > information about this environment so I can start >>> working on >>> > > it? >>> > > > > > After >>> > > > > > > >> > fixing it, I'll share the outcome with the community so >>> > > others can >>> > > > > > do >>> > > > > > > >> the >>> > > > > > > >> > same in other jobs. >>> > > > > > > >> > >>> > > > > > > >> > Cheers! >>> > > > > > > >> > -- >>> > > > > > > >> > Ricardo Zanini Fernandes >>> > > > > > > >> > Vida longa e próspera. >>> > > > > > > >> > >>> > > > > > > >> >>> > > > > > > > >>> > > > > > > >>> > > > > > >>> > > > > > >>> > > > > > -- >>> > > > > > Tibor Zimanyi >>> > > > > > >>> > > > > >>> > > >>> > > --------------------------------------------------------------------- >>> > > To unsubscribe, e-mail: [email protected] >>> > > For additional commands, e-mail: [email protected] >>> > > >>> > > >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: [email protected] >>> For additional commands, e-mail: [email protected] >>> >>>
