Thanks for bringing that up.

You're obviously right, I didn't account for the fact that the build-chain
tool handles all on its own.We're blocked until the PR above is merged and
a new release in NPM appears. Given that it would be a bugfix I suspect
existing version specifier would take the latest available:

kiegroup/github-action-build-chain@v3

which is derived using
https://github.com/kiegroup/jenkins-pipeline-shared-libraries/blob/main/vars/buildChain.groovy
from
https://github.com/apache/incubator-kie-kogito-pipelines/blob/main/.ci/actions/build-chain/action.yml#L36
.

Sorry for the mistake in summary and guidance. So merging is not safe
judging on the PR checks results until we switch to updated build-chain.

Regards
Jan

On Thu, 5 Oct 2023 at 10:45, Marek Novotny <[email protected]> wrote:

> yes, that is correct Toshiya. For some reason the different named forked
> repository is not correctly check out by Build chain used in CI job.
>
> The PR https://github.com/kiegroup/github-action-build-chain/pull/462
> should fix that and then all CI jobs need to upgrade to new version of BC
> to run with that fixed version of BC.
>
> BR,
> Dne 10/5/23 v 09:59 Toshiya Kobayashi napsal(a):
>
> Thank you very much for the progress, Jan and the people involved!
>
> One question:
>
>
> We've already seen green PR checks in incubator-kie-drools
>
> I raised a PR and checked the Jenkins CI yesterday.
> https://github.com/apache/incubator-kie-drools/pull/5545
>
> ```
> # Checkout summary
> [INFO] [apache/incubator-kie-drools]
> [INFO]   Project taken from apache/incubator-kie-drools:main (Branch HEAD
> 02d592c720e43ca028d56e22375a750a9097f694)
> [INFO] [apache/incubator-kie-kogito-runtimes]
> [INFO]   Project taken from apache/incubator-kie-kogito-runtimes:main
> (Branch HEAD 2103ef90832274fb2aeeb55b6e5180263d2ea017)
> [INFO] [apache/incubator-kie-kogito-apps]
> [INFO]   Project taken from apache/incubator-kie-kogito-apps:main (Branch
> HEAD 507ede90bd186f3f6e7fba8454faf19967acfc1f)
> [INFO] [apache/incubator-kie-kogito-examples]
> [INFO]   Project taken from apache/incubator-kie-kogito-examples:main
> (Branch HEAD 868814b52c2ea2caadb839f4652a4cc26fe7912a)
> ```
>
> It didn't pick my PR branch `tkobayas/drools:DROOLS-7570-test-hang-2`. (my
> fork repo name is `drools`, not `incubator-kie-drools`)
>
> So don't we need to wait 
> forhttps://github.com/kiegroup/github-action-build-chain/pull/462 even for a
> single repo PR?
>
> Thanks!
> Toshiya
>
> On Thu, Oct 5, 2023 at 3:39 AM Jan Šťastný <[email protected]> 
> <[email protected]> wrote:
>
>
> Hello,
> we've managed to progress in some areas. Small steps.
>
> [PRs]
> We've already seen green PR checks in incubator-kie-drools and
> incubator-kie-kogito-runtimes repositories. If you have a pending PR, make
> sure you rebase with the latest changes from main, PR checks' behavior
> depends on that.
>
> [Nightly]
> Recent problems with triggers resolved, tonight should trigger first drools
> nightly, to confirm the setup, other repos will be enabled after.
>
> With this we've already found several issues, for some we don't have
> workaround yet.
>
> Most problematic is our inability to run multi-repository builds for PRs,
> so if we have changes related to each other in 3 related repositories they
> are not at the moment tested together. Which is a big problem that is being
> tackled already 
> inhttps://github.com/kiegroup/github-action-build-chain/pull/462 .
>
> We're also seeing docker-related issues in execution of
> incubator-kie-kogito-apps and incubator-kie-kogito-examples PR checks, in
> most cases due to keycloak containers not being started - anyone willing to
> take a look, please jump on that, ping me if needed.
>
> We've also turned everything possible off, and we need to gradually put
> things back to shape. For immediate tasks I would name Apache Nexus
> snapshot deployment, SonarCloud reporting and slightly related -
> fine-grained PR checks.
>
> Regards
> Jan
>
>
> --
> Marek Novotny
> --
>
> RedHat JBoss Middleware
>
> Red Hat Czech s.r.o.
> Purkynova 111
> 612 45 Brno
>
>

Reply via email to