+1 binding (PPMC tiagobento) 🎉 🎉 🎉 [X] Download KIE artifacts are valid. [X] Checksums and PGP signatures are valid. [X] Source code distributions have correct names matching the current release. [X] LICENSE and NOTICE files are correct. [X] All files have license headers if necessary. [X] No compiled archives bundled in source archive. [X] Can compile from source.
I created https://github.com/apache/incubator-kie-issues/issues/1525 for us to follow up on minor issues we found during the verification process. If we find more issues during the IPMC vote, we can use this same EPIC. Feel free to have conversations on that issue as well. THANK YOU all for the time you invested in verifying the release! Regards, Tiago Bento On Wed, Oct 9, 2024 at 10:58 AM Jan Šťastný <[email protected]> wrote: > > [x] Download KIE artifacts are valid. > [x] Checksums and PGP signatures are valid. > [x] Source code distributions have correct names matching the current > release. > [x] LICENSE and NOTICE files are correct. > [x] All files have license headers if necessary. > [x] No compiled archives bundled in source archive. > [ ] Can compile from source. > > Though I was able to compile everything except for kie-tools due to > docker-squash problem in my env. > > +1 > > On Wed, 9 Oct 2024 at 15:48, Luca Molteni <[email protected]> wrote: > > > > > > On 4 Oct 2024, at 23:24, Alex Porcelli <[email protected]> wrote: > > > > > > [X] Download KIE artifacts are valid. > > > [X] Checksums and PGP signatures are valid. > > > [X] Source code distributions have correct names matching the current > > release. > > > [X] LICENSE and NOTICE files are correct. > > > [X] All files have license headers if necessary. > > > [X] No compiled archives bundled in source archive. > > > [ ] Can compile from source. > > > > +1 > > > > I wasn’t able to compile to source kogito-images and kie-tools > > > > Kogito-apps required this property when having podman instead of docker > > installed: > > > > ``` > > -Djib.dockerClient.executable=$(which podman) > > ``` > > > > Kie-tools failed badly on the formatting - I’m not using Go 1.21.9 as > > requested, but 1.23.1 > > > > In addition to make the compilation started on the Mac, I also had to > > install > > > > `brew install helm-docs` > > > > And go imports which is not included while installing go with `brew > > install go` > > > > `go install golang.org/x/tools/cmd/goimports@latest` > > <http://golang.org/x/tools/cmd/goimports@latest> < > > http://golang.org/x/tools/cmd/goimports@latest%60> > > > > If needed I can go further, but I trust the compilation done by other > > members of the communities on easier configuration, as I’m currently on > > macOS 14.7 > > > > Luca > > > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [email protected] > > For additional commands, e-mail: [email protected] > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
