Hi all, Just heads-up about the work for "Remove binaries from test resources on main".
https://github.com/apache/incubator-kie-issues/issues/1602 In drools repo, there were 16 jar files reported. I have resolved them with this PR. https://github.com/apache/incubator-kie-drools/pull/6144 ./incubator-kie-drools/efesto/efesto-core/efesto-common-api/src/test/resources/TestJar.jar ./incubator-kie-drools/efesto/efesto-core/efesto-runtime-manager/efesto-runtime-manager-core/src/test/resources/TestJar.jar ./incubator-kie-drools/efesto/efesto-core/efesto-common-core/src/test/resources/TestJar.jar -> These jars don't contain compiled resources so they are not removed. Just mentioned in "NOTICE-BINARY". ./incubator-kie-drools/drools-compiler/src/test/resources/eventing-example.jar ./incubator-kie-drools/drools-compiler/src/test/resources/KAModelTest.jar ./incubator-kie-drools/drools-compiler/src/test/resources/JarWithSourceFiles.jar ./incubator-kie-drools/drools-test-coverage/test-compiler-integration/src/test/resources/org/drools/mvel/compiler/compiler/xml/changeset/changeset.jar -> These jars are not actually used. Deleted. ./incubator-kie-drools/drools-compiler/src/test/resources/primespoc.jar ./incubator-kie-drools/drools-test-coverage/test-compiler-integration/src/test/resources/only-jar-pojo-not-kjar-no-kmodule-1.0.0.jar ./incubator-kie-drools/drools-test-coverage/test-compiler-integration/src/test/resources/billasurf.jar ./incubator-kie-drools/drools-test-coverage/test-compiler-integration/src/test/resources/kie-project-simple-1.0.0.jar ./incubator-kie-drools/drools-test-coverage/test-compiler-integration/src/test/resources/testEnum.jar ./incubator-kie-drools/kie-ci/src/test/resources/kjar/kjar-module-before.jar ./incubator-kie-drools/kie-ci/src/test/resources/kjar/kjar-module-after.jar ./incubator-kie-drools/drools-legacy-test-util/src/test/resources/billasurf.jar -> Removed these jars. Instead, I created jar projects under `drools-test-coverage-jars` so that these jars will be built and copied to required places. ./incubator-kie-drools/drools-verifier/drools-verifier-drl/src/test/resources/org/drools/verifier/model.jar -> Removed the jar. Instead, I created a jar project `drools-verifier-test-jar` so that the jar will be built and copied to a required place. - In CI, those "jar projects" will be executed before the test projects. So no problem. - In local development, using maven, you may run `test-compiler-integration` before building the jar project. But I added "missing-test-jar-file" profile which automatically detects missing test jars and runs the jar projects. It will not happen again once the test jars are copied. - In local development, using IDE, you may run a specific test which requires the missing test jar and you may hit a test failure. But in this case, junit says "Make sure to build drools-test-coverage-jars first". So you will know what to do. I think that the effects in local development are negligible (or easy to handle). But if any further improvements are possible, it would be great. Cheers, Toshiya
