+1 for removal. Thank you, Tibor
Dňa st 27. 11. 2024, 14:43 Pere Fernandez (apache) <[email protected]> napísal(a): > +1 > > On Wed, 27 Nov 2024 at 03:23, Toshiya Kobayashi < > [email protected]> > wrote: > > > +1 for removal. > > > > > > On Wed, Nov 27, 2024 at 8:16 AM Jason Porter <[email protected]> > > wrote: > > > > > Also in favor of removal. If we need to, we could move to the example > > > repo, but if we don't even need it there, all the better. > > > > > > On 2024/11/26 20:09:38 Alex Porcelli wrote: > > > > +1 to remove! > > > > > > > > On Tue, Nov 26, 2024 at 1:02 PM Tiago Bento <[email protected]> > > > wrote: > > > > > > > > > Hi Jozef, > > > > > > > > > > I'd go for the first option you shared: replacing the UI entirely > by > > > > > cURL invocations. > > > > > > > > > > On Tue, Nov 26, 2024 at 10:32 AM Jozef Marko > > > > > <[email protected]> wrote: > > > > > > > > > > > > Hi everyone, we have an issue with licensing the 'bundle.js' file > > for > > > > > the the Apache KIE 10 release, see the discussion here [1]. > > > > > > > > > > > > All this discussion brought me to an idea, do we really need this > > > file? > > > > > After my investigation, it is used only as the 'jitexecutor-runner' > > > demo > > > > > app available as 'localhost:8080/index.html' once you start 'java > > -jar > > > > > jitexecutor-runner/target/quarkus-app/quarkus-run.jar'. > > > > > > > > > > > > There, you will have a simple webpage with two buttons: > > > > > > > > > > > > 'Choose file' button: > > > > > > This button is for opening a model file. Internally, it calls > > > > > 'fetchSchemaForm' from the 'bundle.js' autogenerates form fields > for > > > the > > > > > selected model. > > > > > > > > > > > > 'Submit' button: > > > > > > This is for model evaluation on the 'localhost:8080/jitdmn' > > > endpoint. It > > > > > internally calls 'handleForm' from the bundle.js > > > > > > > > > > > > Possible actions: > > > > > > > > > > > > * > > > > > > If we check the 'jitexecutor/README' we can do the same demo > using > > > > > 'curl' command, so if there is no heavy usage of the jitexecutor > demo > > > UI, > > > > > we could remove it, and remove also 'bundle.js' from the codebase > > > > > > * > > > > > > We could re-implement 'Choose file' and 'Submit' button handlers > > > without > > > > > the 'bundle.js' probably, as it is basically invoking a rest > endpoint > > > with > > > > > some payload, however for sure it is not so straight forward to > > > > > autogenerate fields in the webpage. We do such autogeneration in > > > > > 'kie-tools' project, what gives as some chance, it is doable as > > > 'kie-tools' > > > > > does not use 'bundle.js' > > > > > > * > > > > > > We could simplify the option above, we could refactor the page, > the > > > > > 'Choose file' would load 'model' part of the payload for 'jitdmn' > > > endpoint, > > > > > but the 'context' payload would user need to provide manually - ie. > > no > > > > > schema reading and generating form fields by the demo app > > > > > > * > > > > > > maybe some other option ... > > > > > > > > > > > > What are your thoughts? Is it possible to remove 'bundle.js' from > > the > > > > > codebase to solve the licensing issue? If yes, who to do it? Do > some > > > of the > > > > > options mentioned sound good for you? > > > > > > > > > > > > [1] > > > > > > > > > > > > > > > > > https://github.com/apache/incubator-kie-kogito-apps/pull/2111/files#r1853279114 > > > > > > > > > > > > > > > > > > Jozef Marko > > > > > > > > > > > > Software Developer > > > > > > > > > > > > [email protected] > > > > > > > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > > To unsubscribe, e-mail: [email protected] > > > > > For additional commands, e-mail: [email protected] > > > > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: [email protected] > > > For additional commands, e-mail: [email protected] > > > > > > > > >
