[
https://issues.apache.org/jira/browse/KNOX-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14285438#comment-14285438
]
J.Andreina commented on KNOX-485:
---------------------------------
Hi Larry McCay ,
Thanks for your comments. I have updated the patch as per your
suggestions along with couple of testcases and have attached it .
Please review the same.
> Gateway deployment directory value is been hardcoded , instead of value being
> read from exposed configuration.
> --------------------------------------------------------------------------------------------------------------
>
> Key: KNOX-485
> URL: https://issues.apache.org/jira/browse/KNOX-485
> Project: Apache Knox
> Issue Type: Bug
> Components: Server
> Affects Versions: 0.5.0
> Reporter: J.Andreina
> Attachments: KNOX-485.1.patch
>
>
> Issue1 :
> ======
> During Gateway startup , deployment directory value is been hardcoded ,
> instead of value being read from available configuration .
> {noformat}
> @Override
> public String getGatewayDeploymentDir() {
> return getGatewayDataDir() + File.separator + "deployments";
> }
> {noformat}
> Issue2:
> ======
> Configuration Name in gateway-default.xml is not same as the name used in
> "org.apache.hadoop.gateway.config.impl.GatewayConfigImpl"
> {noformat}
> private static final String GATEWAY_CONFIG_FILE_PREFIX = "gateway";
> public static final String DEPLOYMENT_DIR = GATEWAY_CONFIG_FILE_PREFIX +
> ".deployment.dir";
> {noformat}
> Incorrect Configuration name in gateway-default.xml
> {noformat}
> <property>
> <name>gateway.gateway.conf.dir</name>
> <value>deployments</value>
> <description>The directory within GATEWAY_HOME that contains gateway
> topology deployments.</description>
> </property>
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
