Hi, I've been digging into Knox for the first time yesterday. I'm a contributor to various other Apache projects and a Hive committer.
I looked at a couple of JIRAs and then a few more random ones and I see a few concerning things: * Some/lots of tickets don't have the final patch attached and only point to a git or svn commit (KNOX-615, KNOX-601, KNOX-640) * I haven't seen a single review being done. Knox Reviewboard is empty[1]. Reviews are hard to do when there's no patch to review anywhere :) * I found a couple of instances where patches were modified before committing without attaching the patch that's really been committed * I see issues being created, committed and closed within minutes ( https://issues.apache.org/jira/browse/KNOX-640) which does not really invite contributions and does not allow anyone to do any reviews or raise objections to issues. This last issue has recently been discussed at length in the Incubator mailing list in a thread called "Concerning Sentry"[2] and I urge you to read that. The suggestion in that thread was to wait at least 24h before committing a change and I think that's reasonable. Your contribution process[3] explicitly mentions that patches have to be attached to JIRA and that reviews are necessary. Just FYI I'm seeing the same practice in the Ambari project and raised the topic there as well[4,5] I understand that you're doing this to make fast progress and you're not doing this to intentionally block external contributions but that's what the net effect may be. So I urge you to look at your development practices and consider changing them. Thanks! Cheers, Lars [1] <https://reviews.apache.org/groups/Knox/> [2] < http://thread.gmane.org/gmane.comp.apache.incubator.general/52126/focus=52351 > [3] <https://cwiki.apache.org/confluence/display/KNOX/Contribution+Process> [4]< http://mail-archives.apache.org/mod_mbox/ambari-dev/201512.mbox/%3CCAD-Ua_gt9TgKTxr12vrKO2kCEad3r97-GUwyB_LmUtFviFHt7A%40mail.gmail.com%3E > [5]< http://mail-archives.apache.org/mod_mbox/ambari-dev/201512.mbox/%3CCAD-Ua_hpjfnYGF6HNuOQqTaUrqXqb0fc97BpqJ%3Dy%2BBw59csR4g%40mail.gmail.com%3E >
