[ https://issues.apache.org/jira/browse/KNOX-816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15945472#comment-15945472 ]
Sandeep More commented on KNOX-816: ----------------------------------- Hello [~coheigea] thanks for the patch ! I have a question, there are some inner classes that are not made static is there a reason why ? e.g. in XmlRewriteRulesDigester.java only RuleFactory.java is made static and not the others. > Make private inner classes static > --------------------------------- > > Key: KNOX-816 > URL: https://issues.apache.org/jira/browse/KNOX-816 > Project: Apache Knox > Issue Type: Improvement > Reporter: Colm O hEigeartaigh > Assignee: Colm O hEigeartaigh > Priority: Trivial > Fix For: 0.13.0 > > Attachments: 0001-KNOX-816-Make-private-inner-classes-static.patch > > > As discussed on KNOX-792, this JIRA is a placeholder for a patch to make all > private inner classes static for performance reasons. -- This message was sent by Atlassian JIRA (v6.3.15#6346)