Hi, Two simple queries on the Knox Token Service:
a) The "token_type" that is returned is "Bearer ". The extra space at the end looks a bit odd - is it a typo? https://github.com/apache/knox/blob/master/gateway-service-knoxtoken/src/main/java/org/apache/hadoop/gateway/service/knoxtoken/TokenResource.java#L50 b) There is a semantic mismatch between the JWTokenAuthority interface and the default implementation of DefaultTokenAuthorityService. Namely, the interface has a method: JWT issueToken(Principal p, String audience, long l) throws TokenServiceException; whereas the DefaultTokenAuthorityService implements this method as: public JWTToken issueToken(Principal p, String algorithm, long expires) https://github.com/apache/knox/blob/master/gateway-server/src/main/java/org/apache/hadoop/gateway/services/token/impl/DefaultTokenAuthorityService.java#L83 I think probably the interface is incorrect here, and instead it should be "algorithm" instead of "audience". WDYT? Colm. -- Colm O hEigeartaigh Talend Community Coder http://coders.talend.com
