Great!
Our maven stuff does need some love.
It definitely makes sense to have a separate dev scenario that doesn't run
the secure tests and I think that is what was done here.
It just isn't obvious enough that it is for dev and that something else
needs to be done for checkin.
Another issue is that "mvn test" doesn't work AFAICT.
This is at least partially due to the need to unpack applications and I
think service definitions as part of the packaging step to get them into
the install directories properly.
On Fri, Sep 8, 2017 at 9:04 AM, Sandeep More <moresand...@gmail.com> wrote:
> Thanks Colm,
> I created a JIRA and referenced your commits against it so we track it :)
>
> The changes seems to work, thanks !
>
> Best,
> Sandeep
>
> On Fri, Sep 8, 2017 at 6:20 AM, Colm O hEigeartaigh <cohei...@apache.org>
> wrote:
>
> > Hi Sandeep,
> >
> > I've fixed the tests - the issue was that I didn't add the
> > maven-dependency-plugin change into the gateway-test-release poms as
> well.
> > Perhaps we should run the release profile in maven by default? Anyway,
> let
> > me know if you run into any more problems with the tests.
> >
> > Colm.
> >
> > On Thu, Sep 7, 2017 at 8:55 PM, Sandeep More <moresand...@gmail.com>
> > wrote:
> >
> > > It appears that the problem occurs when Knox is built with 'ant clean
> > > release' when built with 'ant clean package' it seems to work (also
> works
> > > with pure maven builds). I did not investigate why, may be target
> > 'package'
> > > does not execute the SecureClusterTest.
> > >
> > > Colm,
> > > Asking you since I see your commit since the last time 'ant clean
> > > release' worked
> > > :)
> > > Do you think any changes you made could cause this to break ?
> > >
> > > Best,
> > > Sandeep
> > >
> > >
> > >
> > > On Thu, Sep 7, 2017 at 9:37 AM, Sandeep More <moresand...@gmail.com>
> > > wrote:
> > >
> > > > For some reason after I updated to master my SecureClusterTest test
> is
> > > > failing. I tried checking out to a different location still the same,
> > > > restarting had no affect still the failure.
> > > > The test fails also when I run it in standalone more.
> > > >
> > > > It works when I go back to commit id f4de856.
> > > >
> > > > Also, note that this test is not run with Java 7.
> > > >
> > > > Would like to know if anyone else has the same issue (with Java 8and
> > > > above), most likely i think this is my environment.
> > > >
> > > > Best,
> > > > Sandeep
> > > >
> > > > Java version:
> > > > java version "1.8.0_121"
> > > > Java(TM) SE Runtime Environment (build 1.8.0_121-b13)
> > > >
> > > > OS:
> > > > macOS Sierra
> > > >
> > > > Failure:
> > > > [exec] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time
> elapsed:
> > > > 2.818 sec <<< FAILURE! - in org.apache.hadoop.gateway.Secu
> > reClusterTest
> > > > [exec] basicGetUserHomeRequest(org.apache.hadoop.gateway.
> > > SecureClusterTest)
> > > > Time elapsed: 0.182 sec <<< FAILURE!
> > > > [exec] org.junit.ComparisonFailure:
> > > > [exec] expected:<[{"Path":"/user/guest"}]> but was:<[<html>
> > > > [exec] <head>
> > > > [exec] <meta http-equiv="Content-Type"
> content="text/html;charset=
> > > > ISO-8859-1"/>
> > > > [exec] <title>Error 404 </title>
> > > > [exec] </head>
> > > > [exec] <body>
> > > > [exec] <h2>HTTP ERROR: 404</h2>
> > > > [exec] <p>Problem accessing /gateway/cluster/webhdfs/v1. Reason:
> > > > [exec] <pre> Not Found</pre></p>
> > > > [exec] <hr /><i><small>Powered by Jetty://</small></i>
> > > > [exec] </body>
> > > > [exec] </html>
> > > > [exec] ]>
> > > > [exec] at org.apache.hadoop.gateway.SecureClusterTest.
> > > > basicGetUserHomeRequest(SecureClusterTest.java:223)
> > > > [exec]
> > > > [exec]
> > > > [exec] Results :
> > > > [exec]
> > > > [exec] Failed tests:
> > > > [exec] SecureClusterTest.basicGetUserHomeRequest:223
> > > > expected:<[{"Path":"/user/guest"}]> but was:<[<html>
> > > > [exec] <head>
> > > > [exec] <meta http-equiv="Content-Type"
> content="text/html;charset=
> > > > ISO-8859-1"/>
> > > > [exec] <title>Error 404 </title>
> > > > [exec] </head>
> > > > [exec] <body>
> > > > [exec] <h2>HTTP ERROR: 404</h2>
> > > > [exec] <p>Problem accessing /gateway/cluster/webhdfs/v1. Reason:
> > > > [exec] <pre> Not Found</pre></p>
> > > > [exec] <hr /><i><small>Powered by Jetty://</small></i>
> > > > [exec] </body>
> > > > [exec] </html>
> > > > [exec] ]>
> > > > [exec]
> > > > [exec] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0
> > > >
> > > >
> > > >
> > >
> >
> >
> >
> > --
> > Colm O hEigeartaigh
> >
> > Talend Community Coder
> > http://coders.talend.com
> >
>
