[
https://issues.apache.org/jira/browse/KNOX-1014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16170728#comment-16170728
]
Larry McCay commented on KNOX-1014:
-----------------------------------
[~pzampino] -
This is looking really good!
Couple things for as far as I have gotten in the review process - may have more
later:
1. I notice a lot of hardcoded service names and some mappings - these would be
better done more dynamically so as not to require a compile to add support for
new services (can be a follow up JIRA)
2. I notice a credential lookup from the alias service - this is a great idea
but I think we should probably use a property name sort of key rather than user
name. Too easy to have multiple passwords for the same user for different
contexts. I see this as more of a config item stored in a credential store than
a user based thing. Might be able to be convinced otherwise though. :)
3. question: if a service is in the simple descriptor but unknown by ambari
what happens to the materialized topology?
4. question: if a service is in the simple descriptor but just not installed in
the deployment what happens to the materialized topology?
> Service Discovery and Topology Generation Framework
> ---------------------------------------------------
>
> Key: KNOX-1014
> URL: https://issues.apache.org/jira/browse/KNOX-1014
> Project: Apache Knox
> Issue Type: Sub-task
> Components: Server
> Reporter: Phil Zampino
> Assignee: Phil Zampino
> Labels: kip-8
> Fix For: 0.14.0
>
> Attachments: KNOX-1014.patch
>
>
> Implement the foundation for Service Discovery and Topology Generation.
> * Define simple descriptor format (YAML, JSON, etc...)
> * Local simple descriptor and shared provider configuration discovery
> ** Monitor conf/shared-providers, conf/descriptors similar to the way
> conf/topologies is currently monitored.
> * Ambari service discovery (REST API interactions and model construction)
> ** Configuration
> *** How to plug-in discovery implementations
> *** How to configure authentication (credentials/trust) with the service
> registries
> * Topology assembly from simple descriptor and discovery details
> * Topology deployment
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
