[
https://issues.apache.org/jira/browse/KNOX-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173656#comment-16173656
]
Phil Zampino edited comment on KNOX-1041 at 9/20/17 6:43 PM:
-------------------------------------------------------------
In BaseZookeeperURLManager#getActiveURL():
String result = null;
if (!urls.isEmpty()) {
result = this.urls.peek();
}
Wouldn't the following have the same effect?
String result = this.urls.peek();
Based on the javadoc for ConcurrentLinkedQueue:
public E peek()
Description copied from interface: Queue
Retrieves, but does not remove, the head of this queue, or *returns null if
this queue is empty*.
was (Author: pzampino):
In BaseZookeeperURLManager#getActiveURL():
+ String result = null;
+
+ if (!urls.isEmpty()) {
+ result = this.urls.peek();
+ }
+
Wouldn't the following have the same effect?
String result = this.urls.peek();
Based on the javadoc for ConcurrentLinkedQueue:
public E peek()
Description copied from interface: Queue
Retrieves, but does not remove, the head of this queue, or *returns null if
this queue is empty*.
> High Availability Support For Apache SOLR, HBase & Kafka
> --------------------------------------------------------
>
> Key: KNOX-1041
> URL: https://issues.apache.org/jira/browse/KNOX-1041
> Project: Apache Knox
> Issue Type: New Feature
> Components: Server
> Affects Versions: 0.12.0, 0.13.0
> Reporter: Rick Kellogg
> Assignee: Rick Kellogg
> Fix For: 0.14.0
>
> Attachments: KNOX-1041.patch
>
>
> Provide high-availability/fail-over between Knox and SOLR/HBase/Kafka using
> the existing DefaultHaDispatch mechanism and a customized URLManager
> implementation with knowledge of active hosts in Zookeeper.
> When SOLR Cloud is used the active hosts are stored in Zookeeper under the
> /live_nodes path. The attached custom URLManager implementation queries
> Zookeeper for the active hosts upon startup. In the event of fail-over, it
> updates the internal list of hosts.
> The HS2ZookeeperURLManager implementation used to provide similar
> functionality for Hive was used as a starting point.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
