[ 
https://issues.apache.org/jira/browse/KNOX-1054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16174103#comment-16174103
 ] 

Sandeep More commented on KNOX-1054:
------------------------------------

This is great [~pzampino] !  the patch looks good, I will check it in after I 
run through my builds.
Thanks for the contribution ! 

> DefaultURLManager is not thread-safe
> ------------------------------------
>
>                 Key: KNOX-1054
>                 URL: https://issues.apache.org/jira/browse/KNOX-1054
>             Project: Apache Knox
>          Issue Type: Bug
>          Components: Server
>    Affects Versions: 0.13.0
>            Reporter: Phil Zampino
>            Assignee: Phil Zampino
>             Fix For: 0.14.0
>
>         Attachments: KNOX-1054.patch
>
>
> org.apache.hadoop.gateway.ha.provider.impl.DefaultURLManager is not 
> thread-safe.
> Currently, only the "write" methods are subject to locking. Apparently, there 
> are some assumptions being made about the behavior of the underlying 
> ConcurrentLinkedQueue.
> For instance, if a thread is preempted in setActiveURL(String), and another 
> thread invokes getActiveURL(), the urls.peek() result could be incorrect.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to