[jira] [Commented] (KNOX-1055) Spark page characters "&" should be treated as a delimiter

[Sandeep More (JIRA)]

    [ 
https://issues.apache.org/jira/browse/KNOX-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16179179#comment-16179179
 ] 

Sandeep More commented on KNOX-1055:
------------------------------------

Thanks for the patch [~MarsChan] ! and thumbs up for getting rid of deprecated 
{code} StringTokenizer {code}
I have a couple of suggestions 
1. Could you delete the commented out lines (no need for them to stay as the 
new code obviously works and is an enhancement).
2. Could you also a UnitTest for this use case so we can be sure that it does 
not break the next time we make changes to this method.

Again, thanks for finding the bug and submitting a patch !

Best,
Sandeep

> Spark page characters "&" should be treated as a delimiter
> --------------------------------------------------------------
>
>                 Key: KNOX-1055
>                 URL: https://issues.apache.org/jira/browse/KNOX-1055
>             Project: Apache Knox
>          Issue Type: Improvement
>          Components: Server
>    Affects Versions: 0.13.0
>            Reporter: Mars
>            Priority: Trivial
>              Labels: easyfix
>             Fix For: 0.14.0
>
>         Attachments: KNOX-1055.patch
>
>
> I am a beginner of apache knox. When I use knox to proxy my sparkhistoryui, I 
> meet this problem.
> {noformat} <a 
> href="/history/application_1505879554093_0036/stages/stage?id=0&amp;attempt=0"
>  class="name-link">{noformat}
> Some query parameters in the response body of the spark history ui contain a 
> {noformat}&amp;{noformat}
> org.apache.hadoop.gateway.util.urltemplate.Parser#consumeQueryToken does not 
> handle this case
> {code:java}
> StringTokenizer tokenizer = new StringTokenizer( token, "?&" );
>       while( tokenizer.hasMoreTokens() ) {
>         consumeQuerySegment( builder, tokenizer.nextToken() );
>       }
> {code}
> so,I changed the code block as bellows
> {code:java}
> String[] tokens = token.split("(&amp;|\\?|&)");
>       if (tokens != null){
>         for (String nextToken : tokens){
>           consumeQuerySegment(builder,nextToken);
>         }
>       }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)