[ 
https://issues.apache.org/jira/browse/KNOX-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16192931#comment-16192931
 ] 

Sandeep More commented on KNOX-1064:
------------------------------------

I was able to test the patch and it works as expected, good stuff [~pzampino] !
I will check the patch in. 
Also, I noticed that when I add the *descriptor.json file when Knox is stopped 
the topology is not automatically generated, I think this might be an issue 
with cloud deployments where folks have configuration pushed before Knox gets a 
chance to start, probably open a new JIRA perhaps for this, I don't think we 
need to stop this patch for this.

> Externalize Hadoop Service Configuration Details and Service URL Creation
> -------------------------------------------------------------------------
>
>                 Key: KNOX-1064
>                 URL: https://issues.apache.org/jira/browse/KNOX-1064
>             Project: Apache Knox
>          Issue Type: Bug
>          Components: Server
>    Affects Versions: 0.14.0
>            Reporter: Phil Zampino
>            Assignee: Phil Zampino
>              Labels: kip-8
>             Fix For: 0.14.0
>
>         Attachments: KNOX-1064-001.patch, KNOX-1064-002.patch, 
> KNOX-1064-003.patch, KNOX-1064-004.patch, KNOX-1064-005.patch, 
> KNOX-1064-006.patch, KNOX-1064.patch
>
>
> For the sake of flexibility in terms of the services supported by service 
> discovery and topology generation, the following should be externalized from 
> the code:
> # The set and mapping of service components and their respective 
> configuration details.
> # The service URL generation details.
> The goal is to be able to add/modify these details without having to modify 
> source code.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to