Ahhh - I was wondering when I checked whether someone beat me to it - thanks! :)
On Mon, Jan 8, 2018 at 11:41 AM, Philip Zampino <pzamp...@hortonworks.com> wrote: > I’ve added notes about the commit message format to the committer > workflows described in the contribution page (https://cwiki.apache.org/ > confluence/display/KNOX/Contribution+Process). > > -- > Phil > > > On 1/6/18, 9:40 AM, "larry mccay" <lmc...@apache.org> wrote: > > All - > > Just as a reminder to all committers, when pushing a patch please make > sure > to include the JIRA number and description as part of the commit > message. > > We use the following format which is close enough to the CHANGES file > that > it takes little adjustment at release time to get all the CHANGES noted > properly: > > KNOX-{NNNN} - {JIRA-TITLE} [(contributor via committer)] > > Also, with this in mind it is a good idea to keep the JIRA title short > enough to appear in the CHANGES file without wrapping too badly. > > For the handful of commits that were recently added without proper > messages, we can easily address that for CHANGES updates but going > forward > we should revert the patch and repush with a proper message. > > I will try and make sure that we have the following documented more > clearly > in the contribution page. > > Thanks, > > --larry > > >
