[ 
https://issues.apache.org/jira/browse/KNOX-1116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16319037#comment-16319037
 ] 

ASF subversion and git services commented on KNOX-1116:
-------------------------------------------------------

Commit 6d4756f3d6b6c16949aec2580a5b1698ea69a3eb in knox's branch 
refs/heads/KNOX-998-Package_Restructuring from [~coheigea]
[ https://git-wip-us.apache.org/repos/asf?p=knox.git;h=6d4756f ]

KNOX-1116 - Builds of src distributions result in unexpected result from 
gateway version API.


> Builds of src distributions result in unexpected result from gateway version 
> API
> --------------------------------------------------------------------------------
>
>                 Key: KNOX-1116
>                 URL: https://issues.apache.org/jira/browse/KNOX-1116
>             Project: Apache Knox
>          Issue Type: Improvement
>          Components: Build
>    Affects Versions: 0.14.0
>            Reporter: Phil Zampino
>            Assignee: Colm O hEigeartaigh
>             Fix For: 1.0.0
>
>         Attachments: KNOX-1116.patch
>
>
> When a Knox build is executed outside of a git repo (e.g., src 
> distributions), then the build.hash property in build.properties is not 
> populated with an actual value.
> This manifests as an unexpected response to the gateway version API:
> {
>     "ServerVersion" : {
>        "version" : "0.14.0",
>        "hash" : "${buildNumber}"
> }
> This is due to the fact that the buildnumber-maven-plugin attempts to invoke 
> 'git rev-parse --verify HEAD', which fails because it's not in a git repo.
> This plugin apparently has a facility for specifying an alternate value when 
> an scm error is encountered. It would be nice if Knox could employ that 
> facility to provide a better value than ${buildNumber} in these cases.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to