OK thanks for the explanation Larry! Colm.
On Mon, Jan 15, 2018 at 1:33 PM, larry mccay <lmc...@apache.org> wrote: > Hi Colm - > > I believe that you will find that the classes within those > directories/packages fall under section 2 in the KIP-5 [1] one-pager. > > "2. Provide Adapter classes for any classes that have likely been extended > by consumer > > Determining the specific classes that are currently being extended by our > consumers is going to be a bit tricky. > > There are a number of classes that are explicitly intended to be extended > and I will try and list a few here. > > Tests should help identify others. > > We will need to provide adapter classes and should deprecate them from the > start in order to facilitate a migration away from the old packages. > " > > Since there are existing deployments with explicit mentions of classnames > in topologies and log4j files, we need to ensure backward compatibility for > them. > > thanks! > > --larry > > 1. > https://cwiki.apache.org/confluence/display/KNOX/KIP-5+ > Renaming+of+Knox+Class+Packages > > On Mon, Jan 15, 2018 at 4:52 AM, Colm O hEigeartaigh <cohei...@apache.org> > wrote: > > > Hi Sandeep, > > > > There are two directories remaining with "org.apache.hadoop" - was this > > intentional? > > > > ./gateway-adapter/src/main/java/org/apache/hadoop > > ./gateway-adapter/src/test/java/org/apache/hadoop > > > > Colm. > > > > On Sat, Jan 13, 2018 at 12:05 AM, larry mccay <lmc...@apache.org> wrote: > > > > > Excellent - thanks, Sandeep! > > > > > > On Fri, Jan 12, 2018 at 4:36 PM, Sandeep More <moresand...@gmail.com> > > > wrote: > > > > > > > Hello, > > > > > > > > Just letting everyone know that the changes for renaming Knox > packages > > ( > > > > KNOX-998 <https://issues.apache.org/jira/browse/KNOX-998>) were > > > committed > > > > yesterday. I am not expecting any failures (unless there are custom > > > > extensions) but given the scope of changes there could be some > > unforeseen > > > > breakages. Please let me know if you encounter any breakage, I would > > try > > > to > > > > get it fixed as soon as possible. > > > > > > > > Best, > > > > Sandeep > > > > > > > > On Thu, Aug 31, 2017 at 9:16 PM, Sandeep More <moresand...@gmail.com > > > > > > wrote: > > > > > > > > > All, > > > > > > > > > > As a part of KIP-5 Renaming of Knox Class Packages, I have created > a > > > > > feature branch (KNOX-998-Package_Restructuring) and will be > > committing > > > > my > > > > > changes there. Since this will be a significant refactoring I would > > > like > > > > to > > > > > let folks know well ahead in time that this will be coming, I do > not > > > > expect > > > > > any changes to functionality but if you have external libs that > > depend > > > on > > > > > Knox classes or Knox SDK those might have to be refactored as well > > > (i.e. > > > > > from org.apache.hadoop.gateway.* to org.apache.knox.gateway.*). > > > > > > > > > > I will also try to commit my brach with it's changes later today or > > > > > tomorrow, just wanted to let everyone know if you want to check it > > out > > > ! > > > > > > > > > > Best, > > > > > Sandeep > > > > > > > > > > > > > > > > > > > > -- > > Colm O hEigeartaigh > > > > Talend Community Coder > > http://coders.talend.com > > > -- Colm O hEigeartaigh Talend Community Coder http://coders.talend.com
