Thanks for summarizing the activity around rc-1. Looking forward to rc-2...
On Wed, Jan 31, 2018 at 2:20 PM, larry mccay <lmc...@apache.org> wrote: > Sandeep reported issues with the testing on rc-1 on the branching thread > for 1.0.0 instead of the VOTE thread [1] which indicated that there were > some missed classes and therefore pac4j based KnoxSSO usecases were broken. > > I gave my -1 for the current rc-1 on the other thread and as a result and > Phil committed a fix for the CHANGES file that he raised in this thread > earlier. Sandeep has also committed a patch for addressing the missed > classes. > > I am officially giving this rc a -1 vote on this thread and am canceling > the VOTE for this rc. > > I'll spin RC-2 today. > > Sorry for the mixed up email threads. > > 1. > http://mail-archives.apache.org/mod_mbox/knox-dev/201801. > mbox/%3CCAMFO+3RAZstAq-K0sOrvPfqXW+LC3pZY61d+O= > tswikjr8b...@mail.gmail.com%3E > > On Mon, Jan 29, 2018 at 11:19 AM, Philip Zampino <pzamp...@gmail.com> > wrote: > > > +1 > > > > * Downloaded and built from source (with Java 1.8.0_144) > > * Checked LICENSE and NOTICE files > > * Verified GPG/MD5/SHA signatures for Knox source > > * Checked CHANGES file > > * Ran Knox tests > > * Verified remote configuration management via ZooKeeper > > * Verified knoxcli for listing provider configurations and descriptors in > > ZooKeeper (KNOX-1137) > > * Verified that the relationship changes effected among descriptors and > > provider configs when knox is > > NOT running are correctly established at Knox start-up (KNOX-1144) > > > > > > Just re-iterating the aforementioned CHANGES issue wrt KNOX-1144; Not a > > blocker IMO. > > > > > > > > On Mon, Jan 29, 2018 at 9:43 AM, Philip Zampino <pzamp...@gmail.com> > > wrote: > > > > > The CHANGES file includes a reference to KNOX-1144 > > > <https://issues.apache.org/jira/browse/KNOX-1144>, but the description > > is > > > incorrect. > > > It reads > > > Change Rest Assured "expect" to "then" > > > > > > , but it should be > > > > > > Provider Configuration Reference Relationships Aren't Established > For > > > Existing Descriptors at Gateway Startup > > > > > > It must have applied an intermittent commit message. > > > > > > Not a major problem, IMO, but worth pointing out. > > > > > > On Sat, Jan 27, 2018 at 11:41 AM, larry mccay <lmc...@apache.org> > wrote: > > > > > >> A candidate for the Apache Knox 1.0.0 release is available at: > > >> > > >> https://dist.apache.org/repos/dist/dev/knox/knox-1.0.0/ > > >> > > >> The release candidate is a zip archive of the sources in: > > >> > > >> https://git-wip-us.apache.org/repos/asf/knox.git > > >> Branch v1.0.0 (git checkout -b v{gateway-version}) > > >> > > >> The KEYS file for signature validation is available at: > > >> https://dist.apache.org/repos/dist/release/knox/KEYS > > >> > > >> Please vote on releasing this package as Apache Knox 1.0.0. > > >> > > >> This release is nearly identical to 0.14.0 with the exception of: > > >> > > >> * repackaging of the classes to remove "hadoop" from the package > > >> names > > >> * handful of patches for rounding out service discovery > > >> and topology generation > > >> * moved the Apache Hadoop dependency to Hadoop 3.0 > > >> > > >> The vote is open for the next 72 hours and passes if a majority of at > > >> least three +1 Apache Knox PMC votes are cast. > > >> > > >> [ ] +1 Release this package as Apache Knox 1.0.0 > > >> [ ] -1 Do not release this package because... > > >> > > > > > > > > >
