[ 
https://issues.apache.org/jira/browse/KNOX-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16713713#comment-16713713
 ] 

Kevin Risden commented on KNOX-1615:
------------------------------------

The violations found here also show up in SonarQube. SonarQube checks after a 
build. PMD would fail the build if any new failures arise once we fix the ones 
that are there.

As of commit f54e9d2d47ee5927ab102986a1d240049828ecc9 there are ~400 PMD 
violations. A lot are around useless parenthesis (some I manually checked and 
they help with clarity.) Planning to exclude that rule and see what falls out.

> Enable PMD for source analysis
> ------------------------------
>
>                 Key: KNOX-1615
>                 URL: https://issues.apache.org/jira/browse/KNOX-1615
>             Project: Apache Knox
>          Issue Type: Improvement
>          Components: Build
>            Reporter: Kevin Risden
>            Assignee: Kevin Risden
>            Priority: Major
>             Fix For: 1.3.0
>
>
> PMD allows for static source analysis. This can find issues that other tools 
> may not find.
> {code:java}
> mvn package -DskipTests -Ppackage pmd:check -DtargetJdk=1.8 
> -Dpmd.printFailingErrors=true -Dpmd.failOnViolation=false
> {code}
> This finds violations currently although many are minor.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to