smolnar82 commented on a change in pull request #55: KNOX-1162 - Logging
stacktrace for FATAL messages and displaying a meaningful error message in case
of missing/non-parsable JAAS configuration
URL: https://github.com/apache/knox/pull/55#discussion_r258079051
##########
File path: gateway-service-remoteconfig/pom.xml
##########
@@ -38,6 +38,10 @@
<groupId>org.apache.knox</groupId>
<artifactId>gateway-spi</artifactId>
</dependency>
+ <dependency>
Review comment:
Yes. If there is an issue with the supplied JAAS config it is a
`ConfigurationException`, right?
Moreover `ConfigurationException` is not a checked one so that I did not
have to modify the API. I think it would be an exaggeration to create a new
type of exception just for this purpose if we already have to proper one.
Agreed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
