rlevas commented on issue #56: KNOX-1756 - Knox Gateway TLS Keystore and Alias 
Should be Configurable
URL: https://github.com/apache/knox/pull/56#issuecomment-466526846
 
 
   > I think the existing behavior made sense when it was in 
`data/security/keystores/gateway.jks`. This was a path that was fully owned by 
Knox. Since we are now following the path to the custom keystore, we should be 
more careful about what we overwrite. Not sure how easy it would be to check if 
the identity path is the default vs a configured one?
   
   I guess we can see if the path is the expected default and maybe also see if 
the cert is self-signed and has the DN of the Gateway-created one. If so, we 
blindly overwrite, else we require a `--force`. This seems like it may fall 
under a different issue, but I can fix it in this patch if desired. 
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to