rlevas opened a new pull request #58: KNOX-1791 - MasterService should be a 
field on GatewayServices
URL: https://github.com/apache/knox/pull/58
 
 
   (It is very **important** that you created an Apache Knox JIRA for this 
change and that the PR title/commit message includes the Apache Knox JIRA ID!)
   
   Currently "MasterService" is a string throughout the code base. This should 
be a field on the interface GatewayServices like other services.
   
   - Added `GatewayServices.MASTER_SERVICE` constant.
   - Alphabetized service name constants in `GatewayServices` 
   - Replaced "MasterService" strings speckled throughout the code with 
`GatewayServices.MASTER_SERVICE`
   - Replaced an instance of "SSLService" with "GatewayServices.SSL_SERVICE"
   
   ## How was this patch tested?
   
   (Please explain how this patch was tested. For instance: running automated 
unit/integration tests, manual tests. Please write down your test steps as 
detailed as possible)
   (If this patch involves UI changes, please attach a screen-shot; otherwise, 
remove this)
   
   Please review [Knox Contributing 
Process](https://cwiki.apache.org/confluence/display/KNOX/Contribution+Process#ContributionProcess-GithubWorkflow)
 before opening a pull request.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to