rlevas commented on a change in pull request #59: KNOX-1789 - Refactor
RemoteAliasService to use service loading
URL: https://github.com/apache/knox/pull/59#discussion_r259999555
##########
File path:
gateway-server/src/main/java/org/apache/knox/gateway/services/CLIGatewayServices.java
##########
@@ -70,16 +54,21 @@ public void init(GatewayConfig config, Map<String,String>
options) throws Servic
defaultAlias.setKeystoreService(ks);
defaultAlias.init(config, options);
+ final RemoteConfigurationRegistryClientService registryClientService =
+ RemoteConfigurationRegistryClientServiceFactory.newInstance(config);
+ registryClientService.setAliasService(defaultAlias);
Review comment:
Maybe add this as a doc in the code so it is not changed in the future by
someone that does not fully understand the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
