risdenk commented on a change in pull request #61: KNOX-1793 - DefaultKeystoreService should not validate the signing key on initialization URL: https://github.com/apache/knox/pull/61#discussion_r260761852
########## File path: gateway-server/src/main/java/org/apache/knox/gateway/services/DefaultGatewayServices.java ########## @@ -162,6 +162,8 @@ public void start() throws ServiceLifecycleException { SSLService ssl = (SSLService) services.get(SSL_SERVICE); ssl.start(); + (services.get(TOKEN_SERVICE)).start(); Review comment: If we are going to add this here, we should add the corresponding `stop()` entry. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services