risdenk commented on a change in pull request #60: KNOX-1418 - New KnoxShell
command to build truststore using the gateway server's public certificate
URL: https://github.com/apache/knox/pull/60#discussion_r260766293
##########
File path:
gateway-shell/src/main/java/org/apache/knox/gateway/shell/KnoxSh.java
##########
@@ -155,6 +170,81 @@ public boolean validate() {
public abstract String getUsage();
}
+ private class KnoxBuildTrustStore extends Command {
+
+ private static final String USAGE = "buildTrustStore --gateway server-url";
+ private static final String DESC = "Downloads the gateway server's public
certificate and builds a trust store.";
+ private static final String CLIENT_TRUST_STORE_FILE_NAME =
"gateway-client-trust.jks";
Review comment:
I think we should make it consistent with where the KnoxShell will look for
the truststore. Otherwise they could run the new command and then not be able
to use it.
Probably makes sense to add helper methods to figure out what the correct
paths are using the environment variables or the default values. I think
passing into KnoxShell as optional parameters is probably overkill for this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
