[
https://issues.apache.org/jira/browse/KNOX-1793?focusedWorklogId=205260&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-205260
]
ASF GitHub Bot logged work on KNOX-1793:
----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Feb/19 17:45
Start Date: 27/Feb/19 17:45
Worklog Time Spent: 10m
Work Description: rlevas commented on pull request #61: KNOX-1793 -
DefaultKeystoreService should not validate the signing key on initialization
URL: https://github.com/apache/knox/pull/61#discussion_r260866280
##########
File path:
gateway-server/src/main/java/org/apache/knox/gateway/services/DefaultGatewayServices.java
##########
@@ -51,6 +50,33 @@
private static GatewayMessages log = MessagesFactory.get(
GatewayMessages.class );
+ private static final String[] SERVICE_START_ORDER = new String[]{
Review comment:
I looked at the init method too, but there is a bit more going on.
As for the reverse, the stop order was different than the start order. So
right now stop is not the same as start and would not be the exact reverse as
start. I am not sure what the order really should be, maybe we need to look at
the services and declare an official order. Ideally items will stop in the
reverse order of how they were started. We do not want to stop a service that
is a dependent of some running service.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 205260)
Time Spent: 3h 10m (was: 3h)
> DefaultKeystoreService should not validate the signing key on initialization
> ----------------------------------------------------------------------------
>
> Key: KNOX-1793
> URL: https://issues.apache.org/jira/browse/KNOX-1793
> Project: Apache Knox
> Issue Type: Improvement
> Components: Server
> Affects Versions: 1.3.0
> Reporter: Robert Levas
> Assignee: Robert Levas
> Priority: Major
> Fix For: 1.3.0
>
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> The {{org.apache.knox.gateway.services.security.impl.DefaultKeystoreService}}
> implementation should not validate the _signing_ key on initialization. This
> should be a validation task for users of the signing key.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
