risdenk commented on a change in pull request #70: KNOX-1817 - Fix XSS issues
with Alias API
URL: https://github.com/apache/knox/pull/70#discussion_r264873635
##########
File path:
gateway-service-admin/src/main/java/org/apache/knox/gateway/service/admin/TopologiesResource.java
##########
@@ -360,7 +361,8 @@ public Response
uploadProviderConfiguration(@PathParam("name") String name, @Con
}
} catch (URISyntaxException e) {
log.invalidResourceURI(e.getInput(), e.getReason(), e);
- response = status(Response.Status.BAD_REQUEST).entity("{ \"error\" :
\"Failed to deploy provider configuration " + name + "\" }").build();
+ response = status(Response.Status.BAD_REQUEST).entity("{ \"error\" :
\"Failed to deploy provider configuration " + Encode
+ .forHtml(name) + "\" }").build();
Review comment:
Seems like a weird break? Put `Encode.forHtml(...` on the same line?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
