moresandeep commented on issue #70: KNOX-1817 - Fix XSS issues with Alias API
URL: https://github.com/apache/knox/pull/70#issuecomment-472196288
 
 
   > One change required for sure - new version property not in the right place 
and doesn't follow same naming convention.
   
   Oh right, this needs to be fixed.
   
   > 
   > Also I don't know if we need to url decode the parameters. jax-rs should 
decode them automatically?
   > 
   > * 
https://docs.jboss.org/resteasy/docs/1.0.2.GA/userguide/html/_Encoded_and_encoding.html
   > * 
https://www.concretepage.com/webservices/resteasy-3/rest-web-service-jax-rs-encoded-annotation-example-with-resteasy-3
   > 
   > If the path params are decoded automatically, not sure we need to add the 
url decoding and the added catch exceptions.
   
   You are right, jax-rs does automatically decode params so we don't this.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to