[
https://issues.apache.org/jira/browse/KNOX-1817?focusedWorklogId=212118&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-212118
]
ASF GitHub Bot logged work on KNOX-1817:
----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Mar/19 23:20
Start Date: 12/Mar/19 23:20
Worklog Time Spent: 10m
Work Description: risdenk commented on pull request #70: KNOX-1817 - Fix
XSS issues with Alias API
URL: https://github.com/apache/knox/pull/70#discussion_r264922320
##########
File path:
gateway-service-admin/src/main/java/org/apache/knox/gateway/service/admin/AliasResource.java
##########
@@ -100,15 +105,20 @@ public Response postAlias(@PathParam("topology") final
String topology,
final AliasService as = getAliasService();
try {
+ /* check if the string is properly encoded and expect encoded values */
+ topology = URLDecoder.decode(topology, StandardCharsets.UTF_8.name());
+ alias = URLDecoder.decode(alias, StandardCharsets.UTF_8.name());
+ value = URLDecoder.decode(value, StandardCharsets.UTF_8.name());
Review comment:
Yea sorry wasn't clear. I meant does the url decoding mess up what alias
values can be stored. ie: `kevin%20password` but guess it doesn't matter since
this gets removed anyway :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 212118)
Time Spent: 2h 50m (was: 2h 40m)
> Fix XSS issues with AliasResource
> ---------------------------------
>
> Key: KNOX-1817
> URL: https://issues.apache.org/jira/browse/KNOX-1817
> Project: Apache Knox
> Issue Type: Bug
> Components: Server
> Reporter: Sandeep More
> Assignee: Sandeep More
> Priority: Major
> Fix For: 1.3.0
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
