[
https://issues.apache.org/jira/browse/KNOX-1948?focusedWorklogId=282850&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-282850
]
ASF GitHub Bot logged work on KNOX-1948:
----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Jul/19 19:02
Start Date: 25/Jul/19 19:02
Worklog Time Spent: 10m
Work Description: risdenk commented on pull request #121: KNOX-1948 - If
no rules are defined don't rewrite
URL: https://github.com/apache/knox/pull/121#discussion_r307454470
##########
File path:
gateway-provider-rewrite/src/main/java/org/apache/knox/gateway/filter/rewrite/impl/json/JsonUrlRewriteFilterReader.java
##########
@@ -52,14 +52,19 @@ public JsonUrlRewriteFilterReader(
@Override
protected String filterValueString(String name, String value, String rule ) {
- try {
- Template input = Parser.parseLiteral( value );
- Template output = rewriter.rewrite( resolver, input, direction, rule );
- value = output.getPattern();
- } catch( URISyntaxException e ) {
- LOG.failedToParseValueForUrlRewrite( value );
+ if(rule != null || UrlRewriter.Direction.OUT == direction) {
Review comment:
Might help to add a big comment here about what and why.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 282850)
Time Spent: 20m (was: 10m)
> Knox Parser fails to properly handle comma seperated list of urls
> -----------------------------------------------------------------
>
> Key: KNOX-1948
> URL: https://issues.apache.org/jira/browse/KNOX-1948
> Project: Apache Knox
> Issue Type: Bug
> Components: Server
> Reporter: Sandeep More
> Assignee: Sandeep More
> Priority: Major
> Fix For: 1.4.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> List of urls
> "http://www.ics.uci.edu/pub/ietf/uri/Related,https://test.knox.apache.org/,https://test2.knox.apache.org/";
> is modifiled to
> "http://www.ics.uci.edu/pub/ietf/uri/Related,https:/test.knox.apache.org/,https:/test2.knox.apache.org/";
> forward slash in https is dropped for all the urls except the first one.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
